Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve --auto_diff mode for when GMA is the only changed SDK. #1557

Merged
merged 6 commits into from
Mar 26, 2024

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Mar 14, 2024

Description

Provide details of the change, and generalize the change in the PR title above.

If Android/firebase_dependencies.gradle and ios_pod/Podfile only have changed lines referencing GMA or UMP packages, then allow auto_diff to only specify GMA.

This should greatly speed up "quick" tests when updating only GMA dependencies.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov requested a review from a-maurice March 15, 2024 18:22
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Mar 26, 2024
@jonsimantov jonsimantov enabled auto-merge (squash) March 26, 2024 23:25
@jonsimantov jonsimantov merged commit d05287e into main Mar 26, 2024
35 of 48 checks passed
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Mar 26, 2024
Copy link

github-actions bot commented Mar 26, 2024

❌  Integration test FAILED

Requested by @jonsimantov on commit d05287e
Last updated: Tue Mar 26 18:43 PDT 2024
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FAILURE] [Windows] [x64] [openssl]
(1 failed tests)  ValidationTest.QueriesCannotBeSortedByAnUncommittedServerTimestamp
[TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  QueryNetworkTest.EnableDisableNetwork

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Mar 27, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 27, 2024
@firebase firebase locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants