Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal updates #1563

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Internal updates #1563

merged 1 commit into from
Mar 29, 2024

Conversation

nakirekommula
Copy link
Contributor

Description

Bug fix for AdListener support for NativeAd on iOS.

Testing

N/A

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

Ad event listener delegate is set on nativeAd object in iOS which is different from android where ad event listener is set on adloader.

@nakirekommula nakirekommula added the skip-release-notes Skip release notes check label Mar 28, 2024
@nakirekommula nakirekommula merged commit 95c3540 into main Mar 29, 2024
34 of 47 checks passed
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Mar 29, 2024
Copy link

github-actions bot commented Mar 29, 2024

✅  Integration test succeeded!

Requested by @nakirekommula on commit 95c3540
Last updated: Fri Mar 29 15:31 PDT 2024
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Mar 29, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 29, 2024
@firebase firebase locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants