Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the Windows packaging task size by deleting the .tgz and not building tests. #1606

Merged
merged 10 commits into from
Jun 14, 2024
Merged

Reduce the Windows packaging task size by deleting the .tgz and not building tests. #1606

merged 10 commits into from
Jun 14, 2024

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Jun 11, 2024 •
edited
Loading

Packaging was failing on Windows Debug due to disk space limitations, this PR reduces the space required for packaging.

Description

Provide details of the change, and generalize the change in the PR title above.

https://github.com/firebase/firebase-cpp-sdk/actions/runs/9504804792

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov changed the title When uncompressing a tgz into a package, delete the tgz after uncompr… Reduce the Windows packaging task size by deleting the .tgz and not building tests. Jun 13, 2024
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Jun 13, 2024
@jonsimantov jonsimantov merged commit 2ce9f33 into main Jun 14, 2024
30 checks passed
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jun 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

✅  Integration test succeeded!

Requested by @jonsimantov on commit 2ce9f33
Last updated: Fri Jun 14 04:23 PDT 2024
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 14, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 14, 2024
@firebase firebase locked and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-maurice a-maurice a-maurice approved these changes

Assignees

@a-maurice a-maurice

Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @a-maurice