Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove comments specifying downstream messages #1624

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Remove comments specifying downstream messages #1624

merged 2 commits into from
Jul 10, 2024

Conversation

a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Messaging now only supports receiving downstream messages, so the comments specifying that fields are only used for downstream messages aren't necessary anymore.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Jul 9, 2024
@a-maurice a-maurice requested a review from jonsimantov July 10, 2024 01:15
@a-maurice a-maurice merged commit 11045e1 into main Jul 10, 2024
30 checks passed
@a-maurice a-maurice deleted the am-messaging_docs branch July 10, 2024 20:16
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jul 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

✅  Integration test succeeded!

Requested by @a-maurice on commit 11045e1
Last updated: Wed Jul 10 15:17 PDT 2024
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jul 10, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 10, 2024
@firebase firebase locked and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonsimantov jonsimantov jonsimantov approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-maurice @jonsimantov