Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump actions/download-artifact from 3 to 4.1.7 (#1638)" #1643

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Revert "Bump actions/download-artifact from 3 to 4.1.7 (#1638)" #1643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/cpp-packaging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ jobs:
path: sdk-src

- name: download artifact
uses: actions/download-artifact@v4.1.7
uses: actions/download-artifact@v3
with:
# download-artifact doesn't support wildcards, but by default
# will download all artifacts. Sadly this is what we must do.
Expand Down Expand Up @@ -708,7 +708,7 @@ jobs:
path: sdk-src

- name: download artifact
uses: actions/download-artifact@v4.1.7
uses: actions/download-artifact@v3
with:
# download-artifact doesn't support wildcards, but by default
# will download all artifacts. Sadly this is what we must do.
Expand Down Expand Up @@ -764,7 +764,7 @@ jobs:
needs: [merge_packages]
steps:
- name: download SDK zip
uses: actions/download-artifact@v4.1.7
uses: actions/download-artifact@v3
with:
name: firebase_cpp_sdk.zip
- name: unzip SDK and remove non-Windows files
Expand Down
30 changes: 15 additions & 15 deletions .github/workflows/integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ jobs:
retention-days: ${{ env.artifactRetentionDays }}
- name: Download log artifacts
if: ${{ needs.check_and_prepare.outputs.pr_number && failure() && !cancelled() }}
uses: actions/download-artifact@v4.1.7
uses: actions/download-artifact@v3
with:
path: test_results
name: log-artifact
Expand Down Expand Up @@ -501,7 +501,7 @@ jobs:
retention-days: ${{ env.artifactRetentionDays }}
- name: Download log artifacts
if: ${{ needs.check_and_prepare.outputs.pr_number && failure() && !cancelled() }}
uses: actions/download-artifact@v4.1.7
uses: actions/download-artifact@v3
with:
path: test_results
name: log-artifact
Expand Down Expand Up @@ -606,7 +606,7 @@ jobs:
retention-days: ${{ env.artifactRetentionDays }}
- name: Download log artifacts
if: ${{ needs.check_and_prepare.outputs.pr_number && failure() && !cancelled() }}
uses: actions/download-artifact@v4.1.7
uses: actions/download-artifact@v3
with:
path: test_results
name: log-artifact
Expand Down Expand Up @@ -710,7 +710,7 @@ jobs:
retention-days: ${{ env.artifactRetentionDays }}
- name: Download log artifacts
if: ${{ needs.check_and_prepare.outputs.pr_number && failure() && !cancelled() }}
uses: actions/download-artifact@v4.1.7
uses: actions/download-artifact@v3
with:
path: test_results
name: log-artifact
Expand Down Expand Up @@ -773,7 +773,7 @@ jobs:
with:
ref: ${{needs.check_and_prepare.outputs.github_ref}}
- name: Download Desktop integration tests artifact
uses: actions/download-artifact@v4.1.7
uses: actions/download-artifact@v3
with:
path: testapps/testapps-desktop-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.ssl_variant }}
name: testapps-desktop-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.ssl_variant }}
Expand Down Expand Up @@ -842,7 +842,7 @@ jobs:
retention-days: ${{ env.artifactRetentionDays }}
- name: Download log artifacts
if: ${{ needs.check_and_prepare.outputs.pr_number && failure() && !cancelled() }}
uses: actions/download-artifact@v4.1.7
uses: actions/download-artifact@v3
with:
path: test_results
name: log-artifact
Expand Down Expand Up @@ -907,7 +907,7 @@ jobs:
with:
ref: ${{needs.check_and_prepare.outputs.github_ref}}
- name: Download Desktop integration tests artifact
uses: actions/download-artifact@v4.1.7
uses: actions/download-artifact@v3
with:
path: testapps
name: testapps-desktop-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.ssl_variant }}
Expand Down Expand Up @@ -986,7 +986,7 @@ jobs:
retention-days: ${{ env.artifactRetentionDays }}
- name: Download log artifacts
if: ${{ needs.check_and_prepare.outputs.pr_number && failure() && !cancelled() }}
uses: actions/download-artifact@v4.1.7
uses: actions/download-artifact@v3
with:
path: test_results
name: log-artifact
Expand Down Expand Up @@ -1038,7 +1038,7 @@ jobs:
with:
ref: ${{needs.check_and_prepare.outputs.github_ref}}
- name: Download Android integration tests artifact
uses: actions/download-artifact@v4.1.7
uses: actions/download-artifact@v3
with:
path: testapps/testapps-android-${{ matrix.build_os }}
name: testapps-android-${{ matrix.build_os }}
Expand Down Expand Up @@ -1122,7 +1122,7 @@ jobs:
retention-days: ${{ env.artifactRetentionDays }}
- name: Download log artifacts
if: ${{ needs.check_and_prepare.outputs.pr_number && failure() && !cancelled() }}
uses: actions/download-artifact@v4.1.7
uses: actions/download-artifact@v3
with:
path: test_results
name: log-artifact
Expand Down Expand Up @@ -1168,7 +1168,7 @@ jobs:
with:
ref: ${{needs.check_and_prepare.outputs.github_ref}}
- name: Download iOS integration tests artifact
uses: actions/download-artifact@v4.1.7
uses: actions/download-artifact@v3
with:
path: testapps/testapps-ios-${{ matrix.build_os }}
name: testapps-ios-${{ matrix.build_os }}
Expand Down Expand Up @@ -1300,7 +1300,7 @@ jobs:
retention-days: ${{ env.artifactRetentionDays }}
- name: Download log artifacts
if: ${{ needs.check_and_prepare.outputs.pr_number && failure() && !cancelled() }}
uses: actions/download-artifact@v4.1.7
uses: actions/download-artifact@v3
with:
path: test_results
name: log-artifact
Expand Down Expand Up @@ -1338,7 +1338,7 @@ jobs:
with:
ref: ${{needs.check_and_prepare.outputs.github_ref}}
- name: Download tvOS integration tests artifact
uses: actions/download-artifact@v4.1.7
uses: actions/download-artifact@v3
with:
path: testapps/testapps-tvos-${{ matrix.build_os }}
name: testapps-tvos-${{ matrix.build_os }}
Expand Down Expand Up @@ -1440,7 +1440,7 @@ jobs:
retention-days: ${{ env.artifactRetentionDays }}
- name: Download log artifacts
if: ${{ needs.check_and_prepare.outputs.pr_number && failure() && !cancelled() }}
uses: actions/download-artifact@v4.1.7
uses: actions/download-artifact@v3
with:
path: test_results
name: log-artifact
Expand Down Expand Up @@ -1479,7 +1479,7 @@ jobs:
- name: Install python deps
run: pip install -r scripts/gha/python_requirements.txt
- name: Download log artifacts
uses: actions/download-artifact@v4.1.7
uses: actions/download-artifact@v3
with:
path: test_results
name: log-artifact
Expand Down
Loading