Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify using v1 Cloud Functions #1668

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Specify using v1 Cloud Functions #1668

merged 1 commit into from
Nov 6, 2024

Conversation

a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Firebase Functions now defaults to v2, but the test ones we have are still v1, so add the v1 suffix to keep them as working examples.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Nov 5, 2024
@a-maurice a-maurice requested a review from cynthiajoan November 5, 2024 23:50
@a-maurice a-maurice merged commit ed3f87b into main Nov 6, 2024
32 of 44 checks passed
@a-maurice a-maurice deleted the am-functions_update branch November 6, 2024 01:02
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

Integration test with FLAKINESS (succeeded after retry)

Requested by @a-maurice on commit ed3f87b
Last updated: Tue Nov 5 19:18 PST 2024
View integration test log & download artifacts

Failures Configs
auth [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  FirebaseAuthTest.TestRetainedUser
gma [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  FirebaseGmaTest.TestAdView

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Nov 6, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 6, 2024
@firebase firebase locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants