Skip to content

Commit

Permalink
Restore Firebase pod to closed source location (#4112)
Browse files Browse the repository at this point in the history
  • Loading branch information
paulb777 committed Oct 17, 2019
1 parent 92835a4 commit cc55ecc
Show file tree
Hide file tree
Showing 23 changed files with 42 additions and 49 deletions.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@
CODE_SIGN_STYLE = Automatic;
HEADER_SEARCH_PATHS = (
"$(inherited)",
../../../../Firebase/Firebase/Sources,
../../../CoreOnly/Sources,
"\"${PODS_CONFIGURATION_BUILD_DIR}/FirebaseCore/FirebaseCore.framework/Headers\"",
"\"${PODS_CONFIGURATION_BUILD_DIR}/FirebaseCoreDiagnostics/FirebaseCoreDiagnostics.framework/Headers\"",
"\"${PODS_CONFIGURATION_BUILD_DIR}/FirebaseInstanceID/FirebaseInstanceID.framework/Headers\"",
Expand All @@ -306,8 +306,6 @@
"\"${PODS_ROOT}/Headers/Public\"",
"\"${PODS_ROOT}/Headers/Public/Firebase\"",
"\"${PODS_ROOT}/Headers/Public/FirebaseCoreDiagnosticsInterop\"",
"$(inherited)",
"${PODS_ROOT}/Firebase/Firebase/Firebase/Sources",
);
INFOPLIST_FILE = FirebasePodTest/Info.plist;
LD_RUNPATH_SEARCH_PATHS = (
Expand All @@ -328,7 +326,7 @@
CODE_SIGN_STYLE = Automatic;
HEADER_SEARCH_PATHS = (
"$(inherited)",
../../../../Firebase/Firebase/Sources,
../../../CoreOnly/Sources,
"\"${PODS_CONFIGURATION_BUILD_DIR}/FirebaseCore/FirebaseCore.framework/Headers\"",
"\"${PODS_CONFIGURATION_BUILD_DIR}/FirebaseCoreDiagnostics/FirebaseCoreDiagnostics.framework/Headers\"",
"\"${PODS_CONFIGURATION_BUILD_DIR}/FirebaseInstanceID/FirebaseInstanceID.framework/Headers\"",
Expand All @@ -339,8 +337,6 @@
"\"${PODS_ROOT}/Headers/Public\"",
"\"${PODS_ROOT}/Headers/Public/Firebase\"",
"\"${PODS_ROOT}/Headers/Public/FirebaseCoreDiagnosticsInterop\"",
"$(inherited)",
"${PODS_ROOT}/Firebase/Firebase/Firebase/Sources",
);
INFOPLIST_FILE = FirebasePodTest/Info.plist;
LD_RUNPATH_SEARCH_PATHS = (
Expand Down
29 changes: 29 additions & 0 deletions CoreOnly/Tests/FirebasePodTest/Podfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Uncomment the next line to define a global platform for your project
# platform :ios, '9.0'

target 'FirebasePodTest' do
# Comment the next line if you don't want to use dynamic frameworks
use_frameworks!

pod 'Firebase', :path => '../../../'
pod 'FirebaseABTesting', :path => '../../../'
pod 'FirebaseAnalyticsInterop', :path => '../../../'
pod 'FirebaseAuth', :path => '../../../'
pod 'FirebaseAuthInterop', :path => '../../../'
pod 'FirebaseCoreDiagnostics', :path => '../../../'
pod 'FirebaseCoreDiagnosticsInterop', :path => '../../../'
pod 'FirebaseDatabase', :path => '../../../'
pod 'FirebaseDynamicLinks', :path => '../../../'
pod 'FirebaseFirestore', :path => '../../../'
pod 'FirebaseFunctions', :path => '../../../'
pod 'FirebaseInAppMessaging', :path => '../../../'
pod 'FirebaseInAppMessagingDisplay', :path => '../../../'
pod 'FirebaseInstallations', :path => '../../../'
pod 'FirebaseInstanceID', :path => '../../../'
pod 'FirebaseMessaging', :path => '../../../'
pod 'FirebaseRemoteConfig', :path => '../../../'
pod 'FirebaseStorage', :path => '../../../'

pod 'FirebaseAnalytics' # Analytics is not open source
pod 'FirebasePerformance' # Performance is not open source
end
13 changes: 6 additions & 7 deletions Firebase.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,9 @@ Simplify your iOS development, grow your user base, and monetize more effectivel
}

s.preserve_paths = [
"Firebase/Firebase/.cocoapods.yml",
"Firebase/Firebase/CHANGELOG.md",
"Firebase/Firebase/NOTICES",
"Firebase/Firebase/README.md"
"CoreOnly/CHANGELOG.md",
"CoreOnly/NOTICES",
"CoreOnly/README.md"
]
s.social_media_url = 'https://twitter.com/Firebase'
s.ios.deployment_target = '8.0'
Expand All @@ -38,10 +37,10 @@ Simplify your iOS development, grow your user base, and monetize more effectivel

s.subspec 'CoreOnly' do |ss|
ss.dependency 'FirebaseCore', '6.3.2'
ss.source_files = 'Firebase/Firebase/Sources/Firebase.h'
ss.preserve_paths = 'Firebase/Firebase/Sources/module.modulemap'
ss.source_files = 'CoreOnly/Sources/Firebase.h'
ss.preserve_paths = 'CoreOnly/Sources/module.modulemap'
ss.user_target_xcconfig = {
'HEADER_SEARCH_PATHS' => "$(inherited) ${PODS_ROOT}/Firebase/Firebase/Firebase/Sources"
'HEADER_SEARCH_PATHS' => "$(inherited) ${PODS_ROOT}/Firebase/CoreOnly/Sources"
}
end

Expand Down
29 changes: 0 additions & 29 deletions Firebase/Firebase/Tests/FirebasePodTest/Podfile

This file was deleted.

2 changes: 0 additions & 2 deletions Firestore/Example/Firestore.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -5001,7 +5001,6 @@
GCC_PREFIX_HEADER = "";
HEADER_SEARCH_PATHS = (
"$(inherited)",
"\"${PODS_ROOT}/Firebase/Firebase/Firebase\"",
"\"${PODS_ROOT}/leveldb-library/include\"",
);
INFOPLIST_FILE = "App/iOS/Firestore-Info.plist";
Expand All @@ -5024,7 +5023,6 @@
GCC_PREFIX_HEADER = "";
HEADER_SEARCH_PATHS = (
"$(inherited)",
"\"${PODS_ROOT}/Firebase/Firebase/Firebase\"",
"\"${PODS_ROOT}/leveldb-library/include\"",
);
INFOPLIST_FILE = "App/iOS/Firestore-Info.plist";
Expand Down
2 changes: 1 addition & 1 deletion scripts/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ case "$product-$method-$platform" in

FirebasePod-xcodebuild-*)
RunXcodebuild \
-workspace 'Firebase/Firebase/Tests/FirebasePodTest/FirebasePodTest.xcworkspace' \
-workspace 'CoreOnly/Tests/FirebasePodTest/FirebasePodTest.xcworkspace' \
-scheme "FirebasePodTest" \
"${xcb_flags[@]}" \
build
Expand Down
2 changes: 1 addition & 1 deletion scripts/check_whitespace.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ options=(
git grep "${options[@]}" -- \
':(exclude)Firebase/CoreDiagnostics/FIRCDLibrary/Protogen/nanopb' \
':(exclude)Firebase/CoreDiagnostics/ProtoSupport' \
':(exclude)Firebase/Firebase/NOTICES' \
':(exclude)CoreOnly/NOTICES' \
':(exclude)Firebase/InAppMessaging/ProtoSupport' \
':(exclude)Firebase/InAppMessaging/Analytics/Protogen/nanopb' \
':(exclude)Firestore/Protos/nanopb' \
Expand Down
2 changes: 1 addition & 1 deletion scripts/if_changed.sh
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ else
;;

FirebasePod-*)
check_changes '^(Firebase/Firebase|Firebase.podspec)'
check_changes '^(CoreOnly|Firebase.podspec)'
;;

Core-*)
Expand Down
2 changes: 1 addition & 1 deletion scripts/install_prereqs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ case "$PROJECT-$PLATFORM-$METHOD" in

FirebasePod-iOS-xcodebuild)
gem install xcpretty
bundle exec pod install --project-directory=Firebase/Firebase/Tests/FirebasePodTest --repo-update
bundle exec pod install --project-directory=CoreOnly/Tests/FirebasePodTest --repo-update
;;

Auth-*)
Expand Down
2 changes: 1 addition & 1 deletion scripts/style.sh
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ s%^./%%
\%^(Example|Firebase)/(Auth|AuthSamples|Messaging)/% d
# Keep Firebase.h indenting
\%^Firebase/Firebase/Sources/Firebase.h% d
\%^CoreOnly/Sources/Firebase.h% d
# Checked-in generated code
\%\.pb(objc|rpc)\.% d
Expand Down

0 comments on commit cc55ecc

Please sign in to comment.