noop in notify if env var is present

firebase · Feb 3, 2025 · 8188718 · 8188718
1 parent 4c99c1e
commit 8188718
Showing 1 changed file with 19 additions and 18 deletions.
diff --git a/js/core/src/reflection.ts b/js/core/src/reflection.ts
@@ -225,24 +225,25 @@ export class ReflectionServer {
     });
 
     server.post('/api/notify', async (request, response) => {
-      const { telemetryServerUrl, reflectionApiSpecVersion } = request.body;
-      const url = process.env.GENKIT_TELEMETRY_SERVER ?? telemetryServerUrl;
-      setTelemetryServerUrl(url);
-      logger.debug(`Connected to telemetry server on ${url}`);
-      if (reflectionApiSpecVersion !== GENKIT_REFLECTION_API_SPEC_VERSION) {
-        if (
-          !reflectionApiSpecVersion ||
-          reflectionApiSpecVersion < GENKIT_REFLECTION_API_SPEC_VERSION
-        ) {
-          logger.warn(
-            'WARNING: Genkit CLI version may be outdated. Please update `genkit-cli` to the latest version.'
-          );
-        } else {
-          logger.warn(
-            'Genkit CLI is newer than runtime library. Some feature may not be supported. ' +
-              'Consider upgrading your runtime library version (debug info: expected ' +
-              `${GENKIT_REFLECTION_API_SPEC_VERSION}, got ${reflectionApiSpecVersion}).`
-          );
+      if (!process.env.GENKIT_TELEMETRY_SERVER) {
+        const { telemetryServerUrl, reflectionApiSpecVersion } = request.body;
+        setTelemetryServerUrl(telemetryServerUrl);
+        logger.debug(`Connected to telemetry server on ${telemetryServerUrl}`);
+        if (reflectionApiSpecVersion !== GENKIT_REFLECTION_API_SPEC_VERSION) {
+          if (
+            !reflectionApiSpecVersion ||
+            reflectionApiSpecVersion < GENKIT_REFLECTION_API_SPEC_VERSION
+          ) {
+            logger.warn(
+              'WARNING: Genkit CLI version may be outdated. Please update `genkit-cli` to the latest version.'
+            );
+          } else {
+            logger.warn(
+              'Genkit CLI is newer than runtime library. Some feature may not be supported. ' +
+                'Consider upgrading your runtime library version (debug info: expected ' +
+                `${GENKIT_REFLECTION_API_SPEC_VERSION}, got ${reflectionApiSpecVersion}).`
+            );
+          }
         }
       }
       response.status(200).send('OK');