Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(go): add support for multiple model versions #1575

Merged
merged 11 commits into from
Feb 5, 2025

Conversation

hugoaguirre
Copy link
Contributor

@hugoaguirre hugoaguirre commented Dec 26, 2024

Adding the support for multiple model versions and grouping the versions in the model metadata.

Gemini models being rendered in Dev UI frontpage

image

Model versions being grouped in the Dev UI

image

Playing around with gemini-1.5-flash-8b-latest

image

Checking raw request

image

Checklist (if applicable):

@hugoaguirre hugoaguirre changed the title feature(go): create model references with dynamic config feature(go): add support for multiple model versions Jan 4, 2025
@hugoaguirre hugoaguirre requested a review from pavelgj January 4, 2025 04:43
@hugoaguirre hugoaguirre marked this pull request as ready for review January 4, 2025 04:43
@hugoaguirre hugoaguirre requested a review from apascal07 January 4, 2025 04:43
@hugoaguirre
Copy link
Contributor Author

Hi @pavelgj, @apascal07

Let me know your opinion about this approach.
I wanted to keep the model definition as it previously was because I think it was very simple and verbose.

The only changes added were:

  • Rewrote how the known models are defined in the plugins (adding a new struct named: ai.ModelDetails that encapsulates the model capabilities and its versions)
  • ai.ModelMetadata was updated to add model versions so they can be grouped together

@hugoaguirre hugoaguirre self-assigned this Jan 6, 2025
@falonso81 falonso81 self-requested a review January 8, 2025 18:30
@apascal07
Copy link
Collaborator

How is this to be used in code? I don't see any way to reference the exact version I want to use in a generate call for example.

@hugoaguirre
Copy link
Contributor Author

hugoaguirre commented Feb 3, 2025

How is this to be used in code? I don't see any way to reference the exact version I want to use in a generate call for example.

Feedback addressed in the last commit

@apascal07
Copy link
Collaborator

Overall, looks good. There's an outstanding issue that you are indirectly (but not fully) touching upon here: #1744

It's unrelated to this PR but it might make sense to just combine it, or at least do it just for the versions field and save the rest for another PR.

@hugoaguirre hugoaguirre linked an issue Feb 4, 2025 that may be closed by this pull request
@hugoaguirre hugoaguirre merged commit 0baad30 into main Feb 5, 2025
7 checks passed
@hugoaguirre hugoaguirre deleted the haguirre/addModelVersions branch February 5, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
3 participants