Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align all github workflows to use node v20 #1840

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

tonybaroneee
Copy link
Collaborator

consistency is key

@tonybaroneee tonybaroneee requested a review from pavelgj February 4, 2025 21:59
@github-actions github-actions bot added the config label Feb 4, 2025
@tonybaroneee tonybaroneee changed the title chore: update github workflows to use node v21 chore: align all github workflows to use node v21 Feb 4, 2025
@pavelgj
Copy link
Collaborator

pavelgj commented Feb 4, 2025

actually, I just switched them back to node 20 because we were missing some node 20 specific bugs in presubmits and 20 is our min supported version....

@tonybaroneee
Copy link
Collaborator Author

tonybaroneee commented Feb 4, 2025

actually, I just switched them back to node 20 because we were missing some node 20 specific bugs in presubmits and 20 is our min supported version....

kk updated PR

@tonybaroneee tonybaroneee changed the title chore: align all github workflows to use node v21 chore: align all github workflows to use node v20 Feb 4, 2025
@tonybaroneee tonybaroneee merged commit b27928c into main Feb 4, 2025
7 checks passed
@tonybaroneee tonybaroneee deleted the update-workflows branch February 4, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants