Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js/client): added defineRemoteAction remote action client #1849

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions js/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,12 @@
"require": "./lib/schema.js",
"import": "./lib/schema.mjs",
"default": "./lib/schema.js"
},
"./zod": {
"types": "./lib/zod.d.ts",
"require": "./lib/zod.js",
"import": "./lib/zod.mjs",
"default": "./lib/zod.js"
}
},
"typesVersions": {
Expand All @@ -116,6 +122,9 @@
],
"schema": [
"lib/schema"
],
"zod": [
"lib/zod"
]
}
}
Expand Down
17 changes: 17 additions & 0 deletions js/core/src/zod.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
/**
* Copyright 2025 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

export { z } from 'zod';
60 changes: 60 additions & 0 deletions js/genkit/src/client/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,66 @@
*/

import { Channel } from '@genkit-ai/core/async';
import { z } from '@genkit-ai/core/zod';

interface RunOptions {
headers?: Record<string, string>;
}

export type RemoteAction<I = any, O = any, S = any> = ((
input?: I,
options?: RunOptions
) => Promise<O>) & {
stream(input?: I, opts?: RunOptions): StreamingResponse<O, S>;
};

/**
* Streaming response from an action.
*/
export interface StreamingResponse<O = any, S = any> {
/** Iterator over the streaming chunks. */
stream: AsyncIterable<S>;
/** Final output of the action. */
output: Promise<O>;
}

/**
* Defines a remote action which can be invoked as a function or streamed.
*/
export function defineRemoteAction<
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it just be remoteAction since there's no registry we're defining it into? but on the other hand define feels more consistent with the server side sdk..

I extends z.ZodTypeAny = z.ZodTypeAny,
O extends z.ZodTypeAny = z.ZodTypeAny,
S extends z.ZodTypeAny = z.ZodTypeAny,
Comment on lines +45 to +47
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, not sure what to do about the generics here. We're not actually doing validation here so in some ways I wonder about omitting the schemas for now and having the generics just be the realized types. You shouldn't have to import the zod schema and all of zod just to have the correct types on your remote action.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm super torn on this... my thinking was that if you share zod schema between the client and server, you can reused them here... but not sure how nice it is ergonomically... ideally you should be able to just take the flow (or action) reference and infer all the typing from it...

remoteAction({
  action: myFlow,
  url: 'https://...'
});

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but right now that's not very feasible because trying to import myFlow into a browser environment will blow up the world. Although maybe with a pure type import...

import type { someFlow } from "./flows/someFlow";

remoteAction<typeof someFlow>();

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>(actionOptions: {
url: string;
headers?: Record<string, string>;
inputSchema?: I;
outputSchema?: O;
streamSchema?: S;
}): RemoteAction<z.infer<I>, z.infer<O>, z.infer<S>> {
const action = (
input?: z.infer<I>,
runOptions?: RunOptions
): Promise<z.infer<O>> => {
return runFlow({
url: actionOptions.url,
headers: runOptions?.headers ?? actionOptions.headers,
input,
});
};
(action as RemoteAction<z.infer<I>, z.infer<O>, z.infer<S>>).stream = (
input?: I,
runOptions?: RunOptions
): StreamingResponse<z.infer<O>, z.infer<S>> => {
return streamFlow({
url: actionOptions.url,
headers: runOptions?.headers ?? actionOptions.headers,
input,
});
};

return action as RemoteAction<z.infer<I>, z.infer<O>, z.infer<S>>;
}

const __flowStreamDelimiter = '\n\n';

Expand Down
36 changes: 35 additions & 1 deletion js/genkit/src/client/index.ts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider exporting z from this file as well - import {z} from "genkit" will blow up Next.js if you do it from a file that runs in the browser

Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
/**
* @license
*
* Copyright 2024 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
Expand All @@ -14,4 +16,36 @@
* limitations under the License.
*/

export { runFlow, streamFlow } from './client.js';
/**
* A client library for remotely invoking deployed flows and other actions (e.g. models).
*
* ```ts
* import { defineRemoteAction } from 'genkit/beta/client';
*
* const myFlow = defineRemoteAction({
* url: 'http://.../myFlow',
* inputSchema: z.object({ foo: z.string() }),
* outputSchema: z.string(),
* streamSchema: z.string(),
* });
*
* const { stream } = myFlow.stream(
* { foo: 'bar' },
* { headers: { authentication: getAuthToken() } }
* );
*
* for await (const chunk of stream) {
* console.log(chunk);
* }
* ```
*
* @module
*/

export {
RemoteAction,
StreamingResponse,
defineRemoteAction,
runFlow,
streamFlow,
} from './client.js';
Loading