-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(observability): Add advanced configuration, authentication, and telemetry collection docs #1969
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I made a bunch of nit picky grammatical tweaks you can take or leave.
A few broad callouts I want to make, though:
-
I think we need to decide when and where we refer to "telemetry plugin" and when we refer to "genkit monitoring". Especially since we are doing double-duty with the plugin, wrt "firebase" and "google cloud".
-
In some ways, we are doing a bit of a round-a-bout by pointing the Google Cloud docs to the Firebase instructions (whereas before it was the opposite). It's much improved, no doubt.
- One thing we talked about that could potentially help is making "includeable" snippets that can go into all 3 docs ("Observing AI workflows, Firebase Plugin, Cloud Plugin).
…telemetry collection docs to observability
b3d3eb8
to
eee4365
Compare
eee4365
to
b714155
Compare
b714155
to
b091bff
Compare
Checklist (if applicable):