Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: formatting conventional commit messages and fix some pre-commit breakage #1935 #1978

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

yesudeep
Copy link
Contributor

@yesudeep yesudeep commented Feb 14, 2025

Pre-commits were failing for some folks; this should fix them.

ISSUE: #1935

CHANGELOG:

  • Reverts snake_casing of some fields that broke genkit start.
  • Addresses error handling and parallelized formatting for toml files.
  • Configures the ruff formatter to use requested format.
  • Clean up some lint.
  • Update copyright headers in files missing them.
  • Add scripts to add and check license headers.
  • Add checks to ensure we have a conventional commit message format.
  • Add a commit message template that uses the conventional commit messafe format.
  • Add biomejs configuration for later use.

Checklist (if applicable):

@yesudeep yesudeep requested a review from pavelgj February 14, 2025 08:00
@yesudeep yesudeep force-pushed the yesudeep/fix/fmt-and-types branch 2 times, most recently from 34a5307 to 21c6551 Compare February 14, 2025 08:02
@yesudeep yesudeep changed the title fix: formatting, linting, and schema code generation #1935 fix: formatting conventional commit messages and fix some lint #1935 Feb 14, 2025
@yesudeep yesudeep changed the title fix: formatting conventional commit messages and fix some lint #1935 fix: formatting conventional commit messages and fix some pre-commit breakage #1935 Feb 14, 2025
@yesudeep yesudeep force-pushed the yesudeep/fix/fmt-and-types branch 8 times, most recently from 5f5121e to 03ebefe Compare February 14, 2025 08:16
@yesudeep yesudeep marked this pull request as draft February 14, 2025 10:18
@yesudeep yesudeep force-pushed the yesudeep/fix/fmt-and-types branch 5 times, most recently from 957550e to 5f2f5e4 Compare February 14, 2025 15:57
…age #1935

ISSUE: #1935

CHANGELOG:
- [x] Addresses error handling and parallelized formatting for toml files.
- [x] Configures the ruff formatter to use requested format.
- [x] Clean up some lint.
- [x] Update copyright headers in files missing them.
- [x] Add scripts to add and check license headers.
- [x] Add checks to ensure we have a conventional commit message format.
- [x] Add a commit message template that uses the conventional commit message format.
- [x] Add biomejs configuration for later use.
@yesudeep yesudeep force-pushed the yesudeep/fix/fmt-and-types branch from 5f2f5e4 to 7a2761c Compare February 14, 2025 15:58
@yesudeep yesudeep marked this pull request as ready for review February 14, 2025 16:24
@yesudeep yesudeep requested a review from Irillit February 14, 2025 16:25
@yesudeep yesudeep merged commit 8a40f5b into main Feb 14, 2025
7 checks passed
@yesudeep yesudeep deleted the yesudeep/fix/fmt-and-types branch February 14, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Py] Fail to run ./py/bin/scripts/format_toml_files.sh in pre-commit hooks
2 participants