Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(py): add action kind and refactor register_action usage #2009

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

yesudeep
Copy link
Contributor

@yesudeep yesudeep commented Feb 18, 2025

refactor(py): add action kind and refactor register_action usage

CHANGELOG:

  • Add unit test coverage for the following modules:
    • server
    • action
    • registry
  • update schemas to use snake_case for field names
  • add a headers.py module to contain HttpHeader enum.
  • Define an ActionKind type to enumerate action variants.
  • Refactor the registry methods to reduce redundancy.
  • Push coverage threshold to 80%.

Checklist (if applicable):

@yesudeep yesudeep requested review from kirgrim and Irillit and removed request for kirgrim February 18, 2025 04:57
@yesudeep yesudeep force-pushed the yesudeep/refactor/action-class branch 2 times, most recently from 293ff7c to ade4f8e Compare February 18, 2025 05:23
CHANGELOG:
- [ ] Add unit test coverage for the following modules:
  - [ ] server
  - [ ] action
  - [ ] registry
- [ ] update schemas to use snake_case for field names
- [ ] add a headers.py module to contain HttpHeader enum.
- [ ] Define an ActionKind type to enumerate action variants.
- [ ] Refactor the registry methods to reduce redundancy.
- [ ] Push coverage threshold to 80%.
@yesudeep yesudeep force-pushed the yesudeep/refactor/action-class branch from ade4f8e to 2431021 Compare February 18, 2025 05:26
@yesudeep yesudeep merged commit cedbab1 into main Feb 18, 2025
7 checks passed
@yesudeep yesudeep deleted the yesudeep/refactor/action-class branch February 18, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants