refactor(py): genkit.core.schemas -> genkit.core.schema_types since we also have a schema module #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e also have a schema module Rename the module from schemas to schema_types to avoid collisions with another module called 'schema' that will be ported soon. CHANGELOG: - [ ] Update the name of the module. - [ ] Update references to the name. - [ ] Update ruff configuration to avoid ignoring lint in this module.
yesudeep
force-pushed
the
yesudeep/refactor/typings
branch
from
c6873c0 to
2265ebc
Compare
kirgrim
approved these changes
Feb 18, 2025
Irillit
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(py): genkit.core.schemas -> genkit.core.schema_types since we also have a schema module
Rename the module from schemas to schema_types to avoid collisions with another module called 'schema' that will be ported soon.
CHANGELOG:
Checklist (if applicable):