Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(py): Core VertexAI plugin #2014

Merged
merged 1 commit into from
Feb 20, 2025
Merged

feat(py): Core VertexAI plugin #2014

merged 1 commit into from
Feb 20, 2025

Conversation

Irillit
Copy link
Contributor

@Irillit Irillit commented Feb 18, 2025

This is a small pull request to correct VertexAI. I aim to provide basic corrections here to add more sophisticated features later.

  • I previously created draft and I've used the feedback from there.

Checklist (if applicable):

  • Moved the code from init
  • Separated Gemini model family, defined versions
  • Added retrieval of GCP projectId and location
  • Tested manually

Copy link

google-cla bot commented Feb 18, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Irillit Irillit force-pushed the tatsiana/vertexai-plugin-api branch 7 times, most recently from 95a259e to 9f87f14 Compare February 19, 2025 14:59
@Irillit Irillit marked this pull request as ready for review February 19, 2025 15:02
@Irillit Irillit force-pushed the tatsiana/vertexai-plugin-api branch from 9f87f14 to fa88f1b Compare February 19, 2025 15:09
@Irillit Irillit force-pushed the tatsiana/vertexai-plugin-api branch from fa88f1b to 7b80e44 Compare February 19, 2025 15:21
@github-actions github-actions bot added the docs Improvements or additions to documentation label Feb 19, 2025
@Irillit Irillit self-assigned this Feb 19, 2025
@Irillit
Copy link
Contributor Author

Irillit commented Feb 19, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

With newer Ubuntu I used wrong email. Now it is fixed.

Copy link
Contributor

@kirgrim kirgrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Irillit Irillit merged commit bffc50d into main Feb 20, 2025
7 checks passed
@Irillit Irillit deleted the tatsiana/vertexai-plugin-api branch February 20, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation python Python root
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants