feat: show a link to the Dev UI on running evals #2024
+97
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelgj
reviewed
Feb 19, 2025
pavelgj
reviewed
Feb 19, 2025
| projectRoot?: string | ||
| ): Promise<string | undefined> { | ||
| const serversDir = await findServersDir(projectRoot); | ||
| const toolsJsonPath = path.join(serversDir, 'tools.json'); |
There was a problem hiding this comment.
you're always writing to tools.json? this assumes we track only the last instance of the dev ui? do we want to track all instances?
There was a problem hiding this comment.
I did not know that we'd have multiple Dev UI instances on the same runtime. What would the difference between the instances be?
I can add support for multiple instances if we want, I just need some direction on how we do that for other state files.
Co-authored-by: Pavel Jbanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1641
Checklist (if applicable):