Skip to content

Commit

Permalink
Makefile: do not compile rust/check_linux_pass with old toolchain
Browse files Browse the repository at this point in the history
On Alpine 3.16 (Rust 1.60.0) and Fedora 34 (Rust 1.61.0):

    error[E0658]: deriving `Default` on enums is experimental
       --> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/unicode-width-0.1.13/src/lib.rs:204:30
        |
    204 | #[derive(Clone, Copy, Debug, Default, PartialEq, Eq)]
        |                              ^^^^^^^
        |
        = note: see issue #86985 <rust-lang/rust#86985>
    for more information
        = note: this error originates in the derive macro `Default` (in
    Nightly builds, run with -Z macro-backtrace for more info)

    For more information about this error, try `rustc --explain E0658`.
  • Loading branch information
fishilico committed Jun 13, 2024
1 parent 4c3636e commit 8280af4
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
8 changes: 6 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ endif
# Test rust/cargo availability
ifneq ($(call can-run,$(CARGO) --version),y)
SUBDIRS_BLACKLIST += rust%
else ifeq ($(call can-run,$(RUSTC) --version | grep '^rustc 1\.\(3[0-9]\|4[0-9]\|5[0-9]\)\.'),y)
else ifeq ($(call can-run,$(RUSTC) --version | grep '^rustc 1\.\(3[0-9]\|4[0-9]\|5[0-9]\|6[0-1]\)\.'),y)
# Old versions of rustc (<=1.39) fail to build subtle-2.3.0 because:
# error[E0210]: type parameter `T` must be used as the type parameter for some
# local type (e.g., `MyStruct<T>`)
Expand All @@ -107,8 +107,12 @@ else ifeq ($(call can-run,$(RUSTC) --version | grep '^rustc 1\.\(3[0-9]\|4[0-9]\
# this version of Cargo is older than the `2021` edition, and only supports `2015` and `2018` editions.
# Old versions of rustc (<=1.59) fail to build byteorder-1.5.0 because:
# error: package `byteorder v1.5.0` cannot be built because it requires rustc 1.60 or newer, while the currently active rustc version is 1.56.1
# Old versions of rustc (<=1.61) fail to build unicode-width-0.1.13 because:
# error[E0658]: deriving `Default` on enums is experimental
# note: see issue #86985 <https://github.com/rust-lang/rust/issues/86985> for more information
# note: this error originates in the derive macro `Default` (in Nightly builds, run with -Z macro-backtrace for more info)
SUBDIRS_BLACKLIST += rust/asymkeyfind% rust/check_linux_pass% rust/download_web%
else ifeq ($(call can-run,$(RUSTC) --version | grep '^rustc 1\.\(6[0-4]\)\.'),y)
else ifeq ($(call can-run,$(RUSTC) --version | grep '^rustc 1\.\(6[1-4]\)\.'),y)
# Old versions of rustc (<=1.52) fail to build libz-sys-1.1.8 because:
# error[E0658]: arbitrary expressions in key-value attributes are unstable
# note: see issue #78835 <https://github.com/rust-lang/rust/issues/78835> for more information
Expand Down
2 changes: 1 addition & 1 deletion machines/Dockerfile-alpine3.16
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ COPY . /shared/
CMD ["/run_shared_test.sh"]

# make list-nobuild:
# Global blacklist: latex% rust/asymkeyfind% rust/download_web%
# Global blacklist: latex% rust/asymkeyfind% rust/check_linux_pass% rust/download_web%
# In sub-directories:
# c: x86-read_64b_regs_in_32b_mode
# glossaries:
Expand Down
4 changes: 2 additions & 2 deletions machines/Dockerfile-fedora34
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ COPY . /shared/
CMD ["xvfb-run", "/run_shared_test.sh"]

# make list-nobuild:
# Global blacklist: latex% rust/asymkeyfind% rust/download_web%
# Global blacklist: latex% rust/asymkeyfind% rust/check_linux_pass% rust/download_web%
# In sub-directories:
# c:
# glossaries:
Expand All @@ -76,7 +76,7 @@ CMD ["xvfb-run", "/run_shared_test.sh"]
# rust:
# verification:
# With gcc -m32:
# Global blacklist: latex% rust/asymkeyfind% rust/download_web%
# Global blacklist: latex% rust/asymkeyfind% rust/check_linux_pass% rust/download_web%
# In sub-directories:
# c: gtk_alpha_window
# glossaries:
Expand Down

0 comments on commit 8280af4

Please sign in to comment.