Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

just some corrections #147

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

just some corrections #147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc94121
Update README.md
rozek Jan 16, 2023
fa0098d
Update README.md
rozek Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ A wrapper for the [pigpio C library](https://github.com/joan2937/pigpio) to
enable fast GPIO, PWM, servo control, state change notification and interrupt
handling with **Node.js** on the Raspberry Pi Zero, 1, 2, 3 or 4.

pigpio supports Node.js versions 10, 12, 14, 15 and 16.
pigpio supports Node.js versions 10, 12, 14, 15 and 16 (but version 18 seems to work as well).
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the idea of adding text that says that something might work. In reality, I would also expect pigpio to function with Node.js v18, but I haven't tested it extensively yet.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed. Do you have a recommendation, which tests I should run (without requiring too much external hardware) in order to verify my assumption?


## Contents

Expand Down Expand Up @@ -149,7 +149,7 @@ Continuously move a servo connected to GPIO10 clockwise and anti-clockwise.
```js
const Gpio = require('pigpio').Gpio;

const motor = new Gpio(10, {mode: Gpio.OUTPUT});
const motor = new Gpio(13, {mode: Gpio.OUTPUT});
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should the GPIO number specified here be changed from 10 to 13? In my opinion 10 is the correct GPIO number as it corresponds to the fritzing circuit diagram shown directly above the code here. Please not that the fritzing is for an older Pi 1 which has a 24 pin GPIO header, not a newer Pi with a 40 pin GPIO header.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, doesn't a Pi 1 seem a bit old and no longer too common - most users would no longer benefit from the sown circuit diagrams? I counted 4 Fritzing diagrams which I would volunteer to recreate for, e.g., a RasPi Zero. I should even have any required hardware at hand to actually test the examples in reality (incl. waveform generation which I could check with a pocket oscilloscope)


let pulseWidth = 1000;
let increment = 100;
Expand Down