Some improvements #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For this baecons are use, which tell whether a new state is available The new state is fetched and saved in the nuki list.
Get the current config of the nuki after the pairing to save the nuki using the correct id and name
This is needed as sometimes the notifications are taking longer
Getting all the characteristics all the time, takes a lot of time. Instead of converting the uuids into a handle, just use the handle right away. To make this also work for subscribe and unsubscribe, the pygatt code needs to be patched accordingly.
In case the connection didn't work don't wait too long to try it again.
If connecting or sending commands fails try again up to 5 times
This introduces a mutex and a lock decorator which makes sure the background scanning doesn't use the bluetooth device while the web api is used to trigger commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've done some changes to get the nukibridge also working with pygatt instead of bgapi as my dongle didn't support this. In addition i added a few more calls which the android bridge supports and added background scanning to know when to retrieve the new state.
I've running this at home, connected to my home automation already successfully.