Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add transformation runs #141
Feature/add transformation runs #141
Changes from 12 commits
fe37e04
740b493
1c536fc
741a9bc
ca1a85f
0132c30
f179557
77a6dae
008abb4
83c76a1
09a6ae5
9066d57
9a64100
2487556
13bffa5
1aeec5f
1e665d9
5e1350e
875679e
c390c8f
4979d60
1b1aee6
30338cf
1a5ec7b
b21a322
5c82182
7516e1a
e3e62ed
c3be6df
8deed94
3849f8a
2c2fa6d
5a0fa12
40bd14a
bc648d8
c42d41f
1709106
27931d2
00587b5
10775d9
5e25ebe
f16db58
b495f78
adc741c
315ac86
c148487
ca007f3
b352519
4827893
a052a13
0b2d46a
b896ad0
e6bfd21
6936d29
6aa7939
15a55f3
2589cbe
0cc1669
402758c
6334ff5
9f095e8
1865693
6471698
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've seen cases in the past where the casing of strings in the Fivetran Platform data model could possibly change in the future. Can we make this more future proof and simple to a lower casing search?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey I saw this was added but don't we do
upper(free_type) as free_type
in the staging model?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh you are 100% correct thanks for noticing that. I think it makes more sense to keep casing in staging, but I just realized everywhere else we do a lower albeit in the transforms. I'll do a
lower
in the staging and remove it from the transforms.cc @fivetran-joemarkiewicz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we're using the
does_table_exist
macro and have to create a conditional block to pass all null fields for when table does not exist, I believe it doesn't work with the tmp model so I removed that, and instead wrapped up everything in the staging model as shown. This follows what's done in thestg_fivetran_platform__usage_cost
model