Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/conversions #13

Merged
merged 27 commits into from
Oct 24, 2024
Merged

Feature/conversions #13

merged 27 commits into from
Oct 24, 2024

Conversation

fivetran-reneeli
Copy link
Contributor

@fivetran-reneeli fivetran-reneeli commented Oct 14, 2024

PR Overview

This PR will address the following Issue/Feature:
introduce conversion metrics

This PR will result in the following new package version:

Breaking change. Adding new fields

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Features: Conversion Metrics

  • Introduces the following conversion fields to the Reddit Ads <>_report models (source fields in parenthesis):
    • conversions (click_through_conversion_attribution_window_month)
    • view_through_conversions (view_through_conversion_attribution_window_month)
    • total_items (total_items)
    • total_value (total_value)
  • Introduces the variable <>_conversions_passthrough_metrics to allow additional fields from the source _conversion_report tables.
  • We use the maximum attribution window when considering conversions and therefore retrieve conversions metrics from the click_through_conversion_attribution_window_month (conversions) and view_through_conversion_attribution_window_month (view_through_conversions) fields in the respective source tables. You may bring in additional windows and fields through via the <>_conversions_passthrough_metrics variable. For information on how to configure these variables, refer to the README.

Under the hood

  • Added the respective seed data for the new models in addition to updating relevant documentation.
  • Added documentation explaining potential discrepancies across reporting grains.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • [na] dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • [na] The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

image

If you had to summarize this PR in an emoji, which would it be?

💃

@fivetran-reneeli
Copy link
Contributor Author

will close out issue #3 as well since this is addressed

packages.yml Outdated
# - package: fivetran/reddit_ads_source
# version: [">=0.3.0", "<0.4.0"]

- git: https://github.com/fivetran/dbt_reddit_ads_source.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switch

Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie @fivetran-reneeli great job on this PR! @fivetran-jamie there are a few small changes I would like to be addressed before this is ready for release.

CHANGELOG.md Show resolved Hide resolved
Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fivetran-jamie fivetran-jamie merged commit 52bdeb6 into main Oct 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add documentation on differences among aggregations across different grains
3 participants