-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update/default-schema-change #12
Conversation
integration_tests/dbt_project.yml
Outdated
twitter_organic_account_history_identifer: "twitter_organic_account_history_data" | ||
twitter_organic_organic_tweet_report_identifer: "twitter_organic_organic_tweet_report_data" | ||
twitter_organic_tweet_identifer: "twitter_organic_tweet_data" | ||
twitter_organic_twitter_user_history_identifer: "twitter_organic_twitter_user_history_data" | ||
twitter_account_history_identifer: "account_history" | ||
twitter_organic_tweet_report_identifer: "organic_tweet_report" | ||
twitter_tweet_identifer: "tweet" | ||
twitter_twitter_user_history_identifer: "twitter_user_history" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes were made to ensure the union_data macro was working as expected. We cannot effectively test the union_data macro when the seed files are named different from the expected source names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-joemarkiewicz Was able to successfully run and compile! A few notes before approval.
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages yml version range needs to be bumped up in Step 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
|
||
## Under the Hood: | ||
- All tmp models have been updated to reference the new source name `twitter` (previously `twitter_organic`). ([#12](https://github.com/fivetran/dbt_twitter_organic_source/pull/12)) | ||
- Renamed the seed files to allow for more testing functionality. ([#12](https://github.com/fivetran/dbt_twitter_organic_source/pull/12)) | ||
- Included auto-releaser GitHub Actions workflow to automate future releases. ([#12](https://github.com/fivetran/dbt_twitter_organic_source/pull/12)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup this will be added before merge for all repos. I just added here and will add to the remaining ones before merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added to all relevant repos
- The default schema name has been modified from `twitter_organic` to now be `twitter` to more closely align with the default schema name generated by the Fivetran connector. Please be aware if you were leveraging the previous default schema then you will need to update the `twitter_organic_schema` variable accordingly. | ||
- All identifier variables in the `src_twitter_organic.yml` file have been renamed. If you’re using any of these in your project, please update them accordingly. The changes include: | ||
- Prepending `twitter_organic_*` has been updated to `twitter_*` to align with the schema change. | ||
- The spelling of `*_identifer` has been corrected to `*_identifier`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh yeah this was done to test what happens when variables are misspelled again but never reverted in integration tests. Will update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed your suggestion
Co-authored-by: Avinash Kunnath <[email protected]>
Thanks @fivetran-avinash! Changes addressed and ready for re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm for release!
PR Overview
This PR will address the following Issue/Feature: Issue #10
This PR will result in the following new package version:
v0.3.0
This will be a breaking change since the default schema name is changing from
twitter_organic
totwitter
. Likewise, the underlying source name is making the same change. This could break customers workflows if they were previously relying on the default schema beingtwitter_organic
. Now those users will need to update thetwitter_organic_schema
variable accordingly.Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
I was able to validate these changes are working as expected by simply running the models. As there were no code changes applied to these models, I just needed to confirm that the models would compile and run successfully with the schema name change.
Additionally, we can see that the default schema name is now trying to reference
twitter
as opposed totwitter_organic
when I do not define the schema name variable. Note theTWITTER
schema being the callout.If we look at the live version, we can see this references
TWITTER_ORGANIC
.If you had to summarize this PR in an emoji, which would it be?
🐦