-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make patch update to account for upstream changes #182
Changes from 7 commits
41b5ce3
1dd12c5
c865bef
eb00bcb
e224f41
8e43d9d
6c07eac
cbad986
2b6b2c1
e47da2b
ef99d1c
0083a27
bb47018
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,10 @@ | ||
# dbt_zendesk v0.20.0 | ||
|
||
## [Upstream Under-the-Hood Updates](https://github.com/fivetran/dbt_zendesk_source/blob/main/CHANGELOG.md) from `zendesk_source` Package | ||
- (Affects Redshift only) Updates the `union_zendesk_connections` macro to use a limit 1 instead of limit 0 for empty tables. | ||
- When a table is empty, Redshift ignores explicit data casts and will materialize every column as a `varchar`. Redshift users may experience errors in downstream transformations as a consequence. | ||
- For each staging model, if the source table is not found, the package will create a empty table with 0 rows for non-Redshift warehouses and a table with 1 all-`null` row for Redshift destinations. The 1 row will ensure that Redshift will respect the package's datatype casts. | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we create a Documentation section to mention the movement of the H1 heading? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm I don't see other release notes in other packages mentioning this, and it's so minor I don't think it would have much impact? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh I guess I just added them in my recent ones. https://github.com/fivetran/dbt_zuora/releases/tag/v0.3.1 But it's not a big deal either way. |
||
# dbt_zendesk v0.19.2 | ||
[PR #181](https://github.com/fivetran/dbt_zendesk/pull/181) includes the following updates: | ||
|
||
|
@@ -18,7 +25,6 @@ | |
## Documentation Updates | ||
- [Updated README](https://github.com/fivetran/dbt_zendesk?tab=readme-ov-file#step-4-enabledisable-models-for-non-existent-sources) with instructions on how to disable `brand` and `organization` sources. | ||
|
||
|
||
# dbt_zendesk v0.19.1 | ||
[PR #180](https://github.com/fivetran/dbt_zendesk/pull/180) includes the following update: | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
# Zendesk Support Modeling dbt Package ([Docs](https://fivetran.github.io/dbt_zendesk/)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we move the H1 heading in the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes good reminder There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done! |
||
|
||
<p align="center"> | ||
<a alt="License" | ||
href="https://github.com/fivetran/dbt_zendesk/blob/main/LICENSE"> | ||
|
@@ -13,7 +15,6 @@ | |
<img src="https://img.shields.io/badge/Fivetran_Quickstart_Compatible%3F-yes-green.svg" /></a> | ||
</p> | ||
|
||
# Zendesk Support Modeling dbt Package ([Docs](https://fivetran.github.io/dbt_zendesk/)) | ||
## What does this dbt package do? | ||
- Produces modeled tables that leverage Zendesk Support data from [Fivetran's connector](https://fivetran.com/docs/applications/zendesk) in the format described by [this ERD](https://fivetran.com/docs/applications/zendesk#schemainformation) and build off the output of our [zendesk source package](https://github.com/fivetran/dbt_zendesk_source). | ||
- Enables you to better understand the performance of your Support team. It calculates metrics focused on response times, resolution times, and work times for you to analyze. It performs the following actions: | ||
|
@@ -65,7 +66,7 @@ Include the following zendesk package version in your `packages.yml` file: | |
```yml | ||
packages: | ||
- package: fivetran/zendesk | ||
version: [">=0.19.0", "<0.20.0"] | ||
version: [">=0.20.0", "<0.21.0"] | ||
|
||
``` | ||
> **Note**: Do not include the Zendesk Support source package. The Zendesk Support transform package already has a dependency on the source in its own `packages.yml` file. | ||
|
@@ -290,7 +291,7 @@ This dbt package is dependent on the following dbt packages. These dependencies | |
```yml | ||
packages: | ||
- package: fivetran/zendesk_source | ||
version: [">=0.14.0", "<0.15.0"] | ||
version: [">=0.15.0", "<0.16.0"] | ||
|
||
- package: fivetran/fivetran_utils | ||
version: [">=0.4.0", "<0.5.0"] | ||
|
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,10 @@ | ||
packages: | ||
- git: https://github.com/fivetran/dbt_zendesk_source.git | ||
revision: feature/organization-brand-enable-disable | ||
warn-unpinned: false | ||
# - package: fivetran/zendesk_source | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reminder to switch deps before merging. |
||
# version: [">=0.15.0", "<0.16.0"] | ||
|
||
- package: calogica/dbt_date | ||
version: [">=0.9.0", "<1.0.0"] | ||
version: [">=0.9.0", "<1.0.0"] | ||
|
||
- git: https://github.com/fivetran/dbt_zendesk_source.git | ||
revision: bugfix/redshift_empty_tables | ||
warn-unpinned: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream and "from
zendesk_source
Package" is redundant. I'd suggest keeping one or the other but not both.I'd link directly to the release notes for the source package rather than the CHANGELOG, as the CHANGELOG will change over time. Either that or the release hyperlink (https://github.com/fivetran/dbt_zendesk/blob/main/CHANGELOG.md#dbt_zendesk_source-v0200) I think will be the link? Might want to check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! updated