feat: add indefinitely option to duration picker

flanksource · Feb 10, 2025 · 17134f4 · 17134f4
1 parent c332f68
commit 17134f4
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 2 deletions.
diff --git a/src/api/services/notifications.ts b/src/api/services/notifications.ts
@@ -94,6 +94,10 @@ export const silenceNotification = async (
 export const updateNotificationSilence = async (
   data: Omit<NotificationSilenceItem, "created_at">
 ) => {
+  if (data.until === "indefinitely") {
+    data["until"] = null;
+  }
+
   const res = await IncidentCommander.patch(
     `/notification_silences?id=eq.${data.id}`,
     data

diff --git a/src/api/types/notifications.ts b/src/api/types/notifications.ts
@@ -53,7 +53,7 @@ export type SilenceNotificationResponse = {
   check_id?: string;
   canary_id?: string;
   from: string;
-  until: string;
+  until: string | null;
   description?: string;
   recursive?: boolean;
   namespace?: string;
@@ -94,7 +94,7 @@ export type NotificationSilenceItem = {
   filter?: string;
   error?: string;
   from: string;
-  until: string;
+  until: string | null;
   recursive?: boolean;
   config_id?: string;
   check_id?: string;

diff --git a/src/ui/Dates/TimeRangePicker/TimeRangePicker.tsx b/src/ui/Dates/TimeRangePicker/TimeRangePicker.tsx
@@ -37,6 +37,11 @@ export function TimeRangePicker({
     if (currentRange?.type === "absolute") {
       return `${currentRange.from} - ${currentRange.to}`;
     }
+
+    if (!currentRange?.display) {
+      return "Indefinitely";
+    }
+
     return currentRange?.display;
   }, [currentRange]);
 

diff --git a/src/ui/Dates/TimeRangePicker/rangeOptions.ts b/src/ui/Dates/TimeRangePicker/rangeOptions.ts
@@ -120,6 +120,11 @@ export const rangeOptionsCategories: RangeOptionsCategory[] = [
     name: "Relative time ranges",
     type: "future",
     options: [
+      {
+        type: "relative",
+        display: "Indefinitely",
+        range: "indefinitely"
+      },
       {
         type: "relative",
         display: "5 minutes",