fix: improve canary layout modal #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mainawycliffe
force-pushed
the
1563-canary-modal-fixes
branch
10 times, most recently
from
a99bbb4 to
38b4188
Compare
|
@moshloop is this what you had in mind? |
mainawycliffe
force-pushed
the
1563-canary-modal-fixes
branch
from
3968a70 to
60576da
Compare
mainawycliffe
force-pushed
the
1563-canary-modal-fixes
branch
from
f9cf923 to
a4b569e
Compare
also remove unused component
Closes #1563 fix: change page title on open modal refactor: extract the calculations to own file fix: fix title issues fix: fix issues with canary modal and refactor fix: fix missing namepace fix: fix issues raised in PR for the pr fix: fix modal not opening
mainawycliffe
force-pushed
the
1563-canary-modal-fixes
branch
from
a4b569e to
4a88e46
Compare
Closes #1505 tests: add tests for relationships refactor: rename to CheckLinkedTo refactor: rename to CheckRelationships
mainawycliffe
force-pushed
the
1563-canary-modal-fixes
branch
from
4a88e46 to
b936953
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1563
Closes #1505