chore: update icons #1577
Merged
chore: update icons #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mainawycliffe
approved these changes
Jan 3, 2024
| } | ||
|
|
||
| export const ConfigIcon: React.FC<ConfigIconProps> = memo( | ||
| ({ className = "h-5 mr-1", config, ...props }) => { | ||
| ({ className = "h-5 w-auto mr-1", config, ...props }) => { |
There was a problem hiding this comment.
Just wondering about the mr-1, I think the better practice is to leave the component without a margin and use gap-* or space-x-* utility to add space between elements as needed.
There was a problem hiding this comment.
The only issue with using space-x, is if you forget about it - which happens often
chore: update icons chore: lint fixes
chore: lint fixes chore: update icons
chore: organize imports chore: fix tests
chore: consistent link styling
chore: improve canary table rendering
chore: add react-responsive
chore: fix build error
|
Fixes #1599 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.