Mainawycliffe/issue1580 #1584
Merged
Mainawycliffe/issue1580 #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@mainawycliffe - there are also cases where stdout and stderr both have data e.g. https://deploy-preview-1584--flanksource-demo-stable.netlify.app/playbooks/runs/018cca89-e292-30c0-3ace-0a180244b880 Can we color the stderr text red ? |
mainawycliffe
force-pushed
the
mainawycliffe/issue1580
branch
from
5a4fcdd to
c6ea202
Compare
|
@moshloop I have addressed the above |
mainawycliffe
force-pushed
the
mainawycliffe/issue1580
branch
from
c6ea202 to
174469c
Compare
chore: add tests for playbooks
Closes #1580 fix: show both stderr and stdout if pressent
mainawycliffe
force-pushed
the
mainawycliffe/issue1580
branch
from
174469c to
db17364
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1580