feat: Help link on playbooks resource selector #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
moshloop
reviewed
Feb 20, 2025
| <Tooltip | ||
| className="z-50" | ||
| anchorSelect="#help-resource-selector" | ||
| content="eg: name=grafana type=Kubernetes::Deployment or health=healthy,unhealthy" |
There was a problem hiding this comment.
This should be a hint underneath the text field that is always shown
Suggested change
| content="eg: name=grafana type=Kubernetes::Deployment or health=healthy,unhealthy" | |
| content="Filter the list using queries e.g: name=grafana type=Kubernetes::Deployment or health=healthy,unhealthy" |
And then the help icon is not a tooltop but a straight link to docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #2448