fix: fresh objects for Synchronization executions #181
Conversation
| @@ -1398,10 +1444,23 @@ func (op *AddonOperator) HandleGlobalHookRun(t sh_task.Task, labels map[string]s | |||
| op.MetricStorage.HistogramObserve("{PREFIX}global_hook_run_seconds", d.Seconds(), metricLabels) | |||
| })() | |||
|
|
|||
| logEntry.Infof("Global hook run") | |||
| isSynchronization := hm.BindingType == OnKubernetesEvent && hm.BindingContext[0].Type == types.TypeSynchronization | |||
| shouldRunHook := true | |||
There was a problem hiding this comment.
Can we move this code to a method for this instead of copying it? And why do we add shouldRunHook by the way? :)
There was a problem hiding this comment.
-
I've created a method IsSynchronization.
-
shouldRunHookis needed as GlobalHookRun and ModuleHookRun tasks are now created for bindings withexecuteHookOnSynchronization: false. These tasks only enable emitting events from the binding's Monitor and do not run the hook.
There was a problem hiding this comment.
About the second part:
I was wondering about moving some code out of the Handle* methods. If it is hard or gives no benefits, let's leave things as is.
diafour
force-pushed
the
fix_fresh_objects_on_synchronization_retries
branch
from
d4966f9 to
422f4cf
Compare
There was a problem hiding this comment.
No serious concerns left. The only thing we have to do is updating go.mod after merging flant/shell-operator#261
Overview
Set
objectsin "Synchronization" binding context to an actual state in the cluster.What this PR does / why we need it
See flant/shell-operator#261
Special notes for your reviewer
Does this PR introduce a user-facing change?