Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fresh objects for Synchronization executions #261

Merged
merged 1 commit into from
Mar 18, 2021
Merged

fix: fresh objects for Synchronization executions #261

merged 1 commit into from
Mar 18, 2021

Conversation

diafour
Copy link
Contributor

@diafour diafour commented Mar 11, 2021

Overview

Set objects in "Synchronization" binding context to an actual state in cluster.

What this PR does / why we need it

  • snapshots in monitors are updated without Event tasks until success Synchronization execution
  • fix documentation for "Group" binding context

Special notes for your reviewer

Integration tests are fixed, but there are 3 clusters in use. We need to refactor this part in the future.

Does this PR introduce a user-facing change?

@diafour diafour requested review from zuzzas and nabokihms March 11, 2021 17:38
@diafour diafour force-pushed the fix_fresh_objects_on_synchronization_retries branch from b16bb3e to 474da33 Compare March 12, 2021 08:28
@diafour diafour mentioned this pull request Mar 12, 2021
Merged
nabokihms
nabokihms reviewed Mar 15, 2021
View reviewed changes
test/integration/kube_event_manager/kube_event_manager_test.go Outdated Show resolved Hide resolved
HOOKS.md Outdated Show resolved Hide resolved
pkg/hook/controller/hook_controller.go Show resolved Hide resolved
pkg/shell-operator/operator.go Show resolved Hide resolved
pkg/kube_events_manager/resource_informer.go Outdated Show resolved Hide resolved
pkg/kube_events_manager/resource_informer.go Outdated Show resolved Hide resolved
pkg/kube_events_manager/kube_events_manager_test.go Outdated Show resolved Hide resolved
pkg/hook/controller/kubernetes_bindings_controller.go Show resolved Hide resolved
@diafour diafour force-pushed the fix_fresh_objects_on_synchronization_retries branch from 474da33 to a8278c8 Compare March 17, 2021 10:17
@diafour diafour requested a review from nabokihms March 17, 2021 15:12
nabokihms
nabokihms approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@nabokihms nabokihms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some suggestion for the docs changes, but anyway, looks good and ready to merge.

HOOKS.md Outdated Show resolved Hide resolved
HOOKS.md Outdated Show resolved Hide resolved
HOOKS.md Outdated Show resolved Hide resolved
@diafour @nabokihms
fix: fresh objects for Synchronization executions
ef30770 
- snapshots are updated without Event tasks until success Synchronization execution
- fix documentation for "Group" binding context

Co-authored-by: Maksim Nabokikh <[email protected]>
@diafour diafour force-pushed the fix_fresh_objects_on_synchronization_retries branch from 86f0304 to ef30770 Compare March 18, 2021 17:05
@diafour diafour merged commit f4a0b10 into master Mar 18, 2021
@diafour diafour deleted the fix_fresh_objects_on_synchronization_retries branch March 18, 2021 17:15
@diafour diafour added this to the 1.0.0 milestone Mar 31, 2021
@diafour diafour linked an issue Mar 31, 2021 that may be closed by this pull request
Port waitForSynchronization feature from addon-operator #212
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabokihms nabokihms nabokihms approved these changes

@zuzzas zuzzas Awaiting requested review from zuzzas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Port waitForSynchronization feature from addon-operator
2 participants
@diafour @nabokihms