Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change hook logger to overcome the 64k scanner limit #513

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Change hook logger to overcome the 64k scanner limit #513

merged 2 commits into from
Jul 11, 2023

Conversation

yalosev
Copy link
Contributor

@yalosev yalosev commented Jul 10, 2023

Overview

Change stdout/stderr logger for hooks

What this PR does / why we need it

Avoid 64Kb of a scanner. Implementing custom io.Writer can handle logs of any size

Close(#297)

Special notes for your reviewer

@yalosev yalosev requested a review from nabokihms July 10, 2023 15:17
@yalosev yalosev added the bug Something isn't working label Jul 10, 2023
@yalosev yalosev added the run/tests Run tests on full matrix of k8s versions label Jul 10, 2023
@github-actions github-actions bot removed the run/tests Run tests on full matrix of k8s versions label Jul 10, 2023
@yalosev yalosev marked this pull request as ready for review July 10, 2023 15:45
@nabokihms nabokihms merged commit 97a2b07 into main Jul 11, 2023
@nabokihms nabokihms changed the title Change hook logger Change hook logger to overcome the 64k scanner limit Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabokihms nabokihms nabokihms approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yalosev @nabokihms