Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(golang): Update to Go 1.22 #149

Merged
merged 1 commit into from
Aug 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.20-alpine as builder
FROM golang:1.22-alpine as builder
WORKDIR /build
ADD . /build
RUN apk add --no-cache gcc musl-dev linux-headers git make
Expand Down
24 changes: 13 additions & 11 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,17 +1,20 @@
module github.com/flashbots/rpc-endpoint

go 1.20
go 1.21
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it necessary to make the minimum version v1.21?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, versions older than 1.21 choke on the new toolchain directive below that go 1.22 adds. I'm actually surprised that the Go team didn't consider this, I feel like the toolchain directive should've only been added for newer go versions but I can't find a way to do that.

Basically running into the same issue as: golang/go#65847 (comment)


toolchain go1.22.3

require (
github.com/alicebob/miniredis v2.5.0+incompatible
github.com/cespare/xxhash/v2 v2.2.0
github.com/ethereum/go-ethereum v1.13.11
github.com/cespare/xxhash/v2 v2.3.0
github.com/ethereum/go-ethereum v1.14.7
github.com/go-redis/redis/v8 v8.11.5
github.com/google/uuid v1.3.0
github.com/lib/pq v1.10.7
github.com/metachris/flashbotsrpc v0.7.0
github.com/pkg/errors v0.9.1
github.com/stretchr/testify v1.8.4
github.com/stretchr/testify v1.9.0
golang.org/x/exp v0.0.0-20231110203233-9a3e6036ecaa
)

require (
Expand All @@ -20,17 +23,16 @@ require (
github.com/btcsuite/btcd/chaincfg/chainhash v1.0.1 // indirect
github.com/consensys/bavard v0.1.13 // indirect
github.com/consensys/gnark-crypto v0.12.1 // indirect
github.com/crate-crypto/go-kzg-4844 v0.7.0 // indirect
github.com/crate-crypto/go-kzg-4844 v1.0.0 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/decred/dcrd/dcrec/secp256k1/v4 v4.0.1 // indirect
github.com/dgryski/go-rendezvous v0.0.0-20200823014737-9f7001d12a5f // indirect
github.com/ethereum/c-kzg-4844 v0.4.0 // indirect
github.com/holiman/uint256 v1.2.4 // indirect
github.com/ethereum/c-kzg-4844 v1.0.0 // indirect
github.com/holiman/uint256 v1.3.0 // indirect
github.com/mmcloughlin/addchain v0.4.0 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/supranational/blst v0.3.11 // indirect
golang.org/x/exp v0.0.0-20231110203233-9a3e6036ecaa // indirect
golang.org/x/sync v0.5.0 // indirect
golang.org/x/sync v0.7.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
rsc.io/tmplfunc v0.0.3 // indirect
)
Expand All @@ -40,6 +42,6 @@ require (
github.com/gomodule/redigo v1.8.5 // indirect
github.com/jmoiron/sqlx v1.3.4
github.com/yuin/gopher-lua v0.0.0-20200816102855-ee81675732da // indirect
golang.org/x/crypto v0.17.0 // indirect
golang.org/x/sys v0.16.0 // indirect
golang.org/x/crypto v0.22.0 // indirect
golang.org/x/sys v0.20.0 // indirect
)
Loading
Loading