feat: Add Real-time task report function #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kongfei605
reviewed
Jul 11, 2024
| @@ -20,7 +20,7 @@ func (lt *LocalTasksT) ReportTasks() []types.ReportTask { | |||
| rt := types.ReportTask{Id: id, Clock: t.Clock} | |||
|
|
|||
| rt.Status = t.GetStatus() | |||
| if rt.Status == "running" || rt.Status == "killing" { | |||
| if rt.Status == "killing" { | |||
There was a problem hiding this comment.
原本的日志上报如果是在running状态的话是不会上报的，这里去掉了可以每次心跳上报一次
There was a problem hiding this comment.
running的日志是否有必要上报？只上报错误日志是否就够了？
There was a problem hiding this comment.
如果任务运行的时间过长，比如一两天，但是并不知道该任务运行到哪一步了。实时的话就方便查看
|
Thank you @NeganZhao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加了任务根据心跳间隔实时上报日志功能