add-http_response 添加trace数据 #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kongfei605
reviewed
Jan 11, 2025
| var labels map[string]string | ||
| if ins.Trace != nil && *ins.Trace { | ||
| traceid := uuid.New().String() | ||
| labels = map[string]string{"target": target, "traceid": traceid} |
There was a problem hiding this comment.
traceid不建议添加到label，对于时序指标来说不是稳态
There was a problem hiding this comment.
主要考虑是将同一个请求通过traceid给关联到一起，至于稳态不太理解。能否解释下。
There was a problem hiding this comment.
比如每10秒拨测一次。 这样这个十秒和下一个十秒的指标 label不同，这样的指标会造成tsdb的存储压力
kongfei605
reviewed
Jan 11, 2025
| // request | ||
| DNSDone: func(info httptrace.DNSDoneInfo) { | ||
| dns_time = time.Now() | ||
| fields["dns_time"] = time.Since(start).Seconds() |
There was a problem hiding this comment.
这个插件原有指标也可以修改为毫秒吗，如http_response_response_time
There was a problem hiding this comment.
可以改，为了兼容老的用户告警，最好新增一个 xxx_time_ms 指标
|
已重新提交 |
|
Thank you @fedocx |
|
v0.4.2 版本已发布 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#659