Skip finish-args-not-defined for extensions

flathub-infra · Nov 28, 2023 · 83610e6 · 83610e6
1 parent d47ac5c
commit 83610e6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/flatpak_builder_lint/checks/finish_args.py b/flatpak_builder_lint/checks/finish_args.py
@@ -109,8 +109,10 @@ def check_build(self, path: str) -> None:
         else:
             is_baseapp = False
 
+        is_extension = metadata.get("extension")
+
         permissions = metadata.get("permissions", {})
-        if not permissions and not is_baseapp:
+        if not permissions and not (is_baseapp or is_extension):
             self.errors.add("finish-args-not-defined")
             return
 

diff --git a/tests/test_builddir.py b/tests/test_builddir.py
@@ -10,8 +10,7 @@ def run_checks(filename: str) -> dict:
 def test_builddir_appid() -> None:
     errors = {
             'appid-ends-with-lowercase-desktop',
-            'appid-uses-code-hosting-domain',
-            'finish-args-not-defined'
+            'appid-uses-code-hosting-domain'
             }
     ret = run_checks("tests/builddir/appid")
     found_errors = set(ret["errors"])
@@ -81,8 +80,7 @@ def test_builddir_baseapp() -> None:
 def test_builddir_extension() -> None:
     errors = {
         "appstream-missing-appinfo-file",
-        "appstream-metainfo-missing",
-        "finish-args-not-defined"
+        "appstream-metainfo-missing"
     }
 
     ret = run_checks("tests/builddir/extension")