appstream: Add a check for missing timestamps in catalogue data

See flathub-infra/website#4527

flatpak_builder_lint/appstream.py

@@ -152,3 +152,7 @@ def get_icon_filename(path: str) -> str | None:
     if icons := parse_xml(path).xpath("/components/component[1]/icon[@type='cached']"):
         return str(icons[0].text)
     return None
+
+
+def all_release_has_timestamp(path: str) -> bool:
+    return not parse_xml(path).xpath("//releases/release[not(@timestamp)]")

flatpak_builder_lint/checks/metainfo.py

@@ -91,6 +91,13 @@ def _validate(self, path: str, appid: str) -> None:
                 + f" does not match the FLATPAK_ID: {appid}. Please see the docs for more details"
             )
 
+        if not appstream.all_release_has_timestamp(appstream_path):
+            self.errors.add("appstream-release-tag-missing-timestamp")
+            self.info.add(
+                "appstream-release-tag-missing-timestamp: A release tag is missing timestamp."
+                + " This is autogenerated and indicates an issue in Metainfo release tags"
+            )
+
         if appstream.component_type(appstream_path) not in (
             "desktop",
             "desktop-application",

tests/builddir/appstream-missing-timestamp/files/share/appdata/org.flathub.appstream_no_timestamp.appdata.xml

@@ -0,0 +1,29 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<component type="desktop-application">
+  <id>org.flathub.appstream_no_timestamp</id>
+  <provides>
+    <id>org.flathub.appstream_no_timestamp.desktop</id>
+  </provides>
+  <launchable type="desktop-id">org.flathub.appstream_no_timestamp.desktop</launchable>
+  <metadata_license>CC0-1.0</metadata_license>
+  <project_license>GPL-2.0+</project_license>
+  <name>Foo Bar</name>
+  <developer_name>Flathub</developer_name>
+  <summary>Foo foo foo foo</summary>
+  <url type="homepage">https://flathub.org</url>
+  <description>
+    <p>An example desktop application</p>
+  </description>
+  <screenshots>
+    <screenshot type="default">
+      <caption>Tux</caption>
+      <image>https://upload.wikimedia.org/wikipedia/commons/a/af/Tux.png</image>
+      <caption>foofoo</caption>
+    </screenshot>
+  </screenshots>
+  <url type="bugtracker">https://flathub.org</url>
+  <content_rating type="oars-1.1"/>
+  <releases>
+    <release version="0.0.1" date="2020-08-28"/>
+  </releases>
+</component>

tests/builddir/appstream-missing-timestamp/files/share/applications/org.flathub.appstream_no_timestamp.desktop

@@ -0,0 +1,9 @@
+[Desktop Entry]
+Name=Example
+GenericName=Example
+Comment=Example
+Exec=Example %U
+Icon=org.flathub.appstream_no_timestamp
+Type=Application
+Categories=Network;
+Version=1.1

tests/builddir/appstream-missing-timestamp/metadata

@@ -0,0 +1,8 @@
+[Application]
+name=org.flathub.appstream_no_timestamp
+runtime=org.gnome.Platform/x86_64/45
+sdk=org.gnome.Sdk/x86_64/45
+command=foo
+
+[Context]
+filesystems=xdg-download;

tests/test_builddir.py

@@ -284,3 +284,9 @@ def test_builddir_xdg_dir_access() -> None:
     }
     for e in errors:
         assert e in found_errors
+
+
+def test_builddir_appstream_missing_timestamp() -> None:
+    ret = run_checks("tests/builddir/appstream-missing-timestamp")
+    found_errors = set(ret["errors"])
+    assert "appstream-release-tag-missing-timestamp" in found_errors