Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ref_branch and target_repo mismatches for known branches #215

Closed
wants to merge 1 commit into from

Conversation

bbhtt
Copy link
Contributor

@bbhtt bbhtt commented Nov 28, 2023

Allow ref_branch and target_repo mismatches for known branches

Only verify that "stable" refs don't end up in beta repos and
vice-versa. For any other arbitrary ref branches it is not possible to
tell the intended target repo. So unless the ref_branch matches some
known branches that are already in use and have some significance return
"flat-manager-branch-repo" mismatch error

I assume the target_repo on flathub is fixed and can only be stable, beta or test.

The only other case where "branch" is used in manifest is for extensions, but those aren't checked here, and baseapps are exempt too. I could find only these two in known branches. If the list gets too long, might need to figure out a way to load it better.

I have no way of testing this due to not having access to a flathub like backend, hence draft.

Only verify that "stable" refs don't end up in beta repos and
vice-versa. For any other arbitrary ref branches it is not possible to
tell the intended target repo. So unless the ref_branch matches some
known branches that are already in use and have some significance return
"flat-manager-branch-repo" mismatch error
@barthalion
Copy link
Member

I ended up going with this: 9c2a70d

Not because yours is worse or wrong, I just didn't notice you opened a PR. The long story short is that only builds targetting the test repo (which isn't even an actual repo, just a construct used by buildbot) are allowed to use branch different than "test". This is an implementation detail of our buildbot config, but we're going to stick with it for now.

@barthalion barthalion closed this Dec 1, 2023
@bbhtt
Copy link
Contributor Author

bbhtt commented Dec 2, 2023

Sure

@bbhtt bbhtt deleted the ref-mismatches branch February 26, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants