Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile SDL Mixer X, add HAVE_MIXERX=1 flag to SRB2 compile #68

Closed
wants to merge 10 commits into from

Conversation

riomccloud
Copy link
Contributor

Tries to fix #32
Still testing, not sure it'll work

@flathubbot
Copy link
Contributor

Started test build 111979

@flathubbot
Copy link
Contributor

Build 111979 failed

@flathubbot
Copy link
Contributor

Started test build 111989

@flathubbot
Copy link
Contributor

Build 111989 failed

@flathubbot
Copy link
Contributor

Started test build 111997

@flathubbot
Copy link
Contributor

Build 111997 failed

@flathubbot
Copy link
Contributor

Started test build 112037

@flathubbot
Copy link
Contributor

Build 112037 failed

@flathubbot
Copy link
Contributor

Started test build 112049

@flathubbot
Copy link
Contributor

Build 112049 failed

@flathubbot
Copy link
Contributor

Started test build 112074

@flathubbot
Copy link
Contributor

Build 112074 failed

@flathubbot
Copy link
Contributor

Started test build 112080

@flathubbot
Copy link
Contributor

Build 112080 failed

@flathubbot
Copy link
Contributor

Started test build 112090

@flathubbot
Copy link
Contributor

Build 112090 failed

@riomccloud
Copy link
Contributor Author

Not sure what's the problem here... SDL2 and SDL Mixer X seems to be fine, but SRB2 fails to build. IDK if I need to compile extra components with SDL Mixer X (and which), or is something related to Flathub's SDL...

@flathubbot
Copy link
Contributor

Started test build 112161

@flathubbot
Copy link
Contributor

Build 112161 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/94975/org.srb2.SRB2.flatpakref

@riomccloud
Copy link
Contributor Author

It compiled normally, but the SRB2 still doesn't play MIDI. For a moment I thought I would need to build additional SDL Mixer X components, but even with them it doesn't work. Now, SRB2 asks for a missing "Timidity" library, that should be included with base SDL Mixer X.

image

During build, tho, it mentions Timidity two times:

image
image

No idea what's the problem here... @katsy any idea?

@bitten2up
Copy link

It compiled normally, but the SRB2 still doesn't play MIDI. For a moment I thought I would need to build additional SDL Mixer X components, but even with them it doesn't work. Now, SRB2 asks for a missing "Timidity" library, that should be included with base SDL Mixer X.

image

During build, tho, it mentions Timidity two times:

image image

No idea what's the problem here... @katsy any idea?

you need fluidsynth, give me a sec, im going to try and comment the changes needed

Copy link

@bitten2up bitten2up left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add fluidsynth's sources (hopefully)

org.srb2.SRB2.yaml Show resolved Hide resolved
@bitten2up
Copy link

also don't use SDL-Mixer-X on 2.6.0 until 2.2.14, there is a bug that causes it to crash

would of put it on master, but it got put to next instead

@riomccloud
Copy link
Contributor Author

also don't use SDL-Mixer-X on 2.6.0 until 2.2.14

Sorry, I didn't understand. What do you refer with "2.2.14"?

@hazepastel
Copy link
Contributor

2.2.14 is the next stable release of SRB2. 2.2.13 is the current, and it was discovered that verison 2.6.0 of SDL Mixer X causes a startup crash. It's been fixed upstream for 2.2.14.

So you either need to use an older version of Mixer X or wait an indefinite amount of time for 2.2.14.

@riomccloud
Copy link
Contributor Author

Ah, sure. Thanks.

@riomccloud
Copy link
Contributor Author

riomccloud commented Apr 8, 2024

Tried building with older SDL Mixer X versions, but no success (2.5.0 causes the same bug as the latest, and 2.2.0 seems to not allow building without additional unnecessary modules). For now, I built the latest version, that should work when SRB2 v2.2.14 releases. Thank you guys for the help! ^^

@flathubbot
Copy link
Contributor

Started test build 113117

@flathubbot
Copy link
Contributor

Build 113117 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/95924/org.srb2.SRB2.flatpakref

@riomccloud riomccloud closed this by deleting the head repository Nov 8, 2024
@bitten2up
Copy link

0_0

Copy link
Collaborator

@ghisvail ghisvail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manifest looks good to me. Few suggestions, needs validation once built.

org.srb2.SRB2.yaml Show resolved Hide resolved
org.srb2.SRB2.yaml Show resolved Hide resolved
@ghisvail
Copy link
Collaborator

ghisvail commented Nov 9, 2024

@riomccloud was this PR closed by accident?

@riomccloud
Copy link
Contributor Author

@ghisvail Oops! Yes, I've closed it by accident.

@ghisvail ghisvail mentioned this pull request Nov 9, 2024
@ghisvail
Copy link
Collaborator

ghisvail commented Nov 9, 2024

Resumed in #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIDI music not supported
5 participants