Notebooks:images live in images/ subdir next to notebooks #1270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on mostly in-person discussion, this reverts the recent change that uses github links to host images for the jupyter notebooks (for a few reasons - offline access, possibly problematic firewalls (including China's firewalls which occasionally block US/Europe hosted sites), Github maybe someday blocking third-party referrers for embedded images, avoiding future updates to images changing content in old software releases, and avoiding commitment to keeping those files exactly there to avoid breaking notebooks in old software), moving back to using the images that are installed with caimanmanager.
It also changes the docs that told users to cd into caiman_data/demos/notebooks before launching Jupyter, which leads to problems.
At the heart of this is a (security?) restriction Jupyter has for its HTML rendering - it refuses to serve images from locations where it would need to step backwards through the filesystem to find them (python is allowed to go anywhere, HTML path resolution is not - Jupyter doesn't want to potentially act as a webserver for your entire hard drive).
If in the future users see rendering issues like this we'll need to keep in mind that they may have launched jupyter from the wrong place.
Will leave this PR in place for a few days to allow for any discussion needed.