chore!: remove all leftover deprecated symbols #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor refactoring of example app Live Web Demo introduction dialog
JaffaKetchup
requested review from
ibrierley,
mootw,
TesteurManiak and
josxha
|
@ibrierley @mootw @TesteurManiak @josxha Would be great if this could be reviewed! It should hopefully make things simpler/less confusing for other PRs. |
|
Can do! |
josxha
requested changes
Nov 22, 2023
|
The changes are looking good to me. 👍🏼
|
josxha
approved these changes
Nov 22, 2023
|
Ready to merge 🎉 |
|
Ah, already fixed Inno in 706ce4, but shouldn't cause conflicts so no worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #1726 to function correctly. Makes #1724 redundant.
Also includes a minor refactoring of example app Live Web Demo introduction dialog.