chore: refactor example app #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using flutter_map_cancellable_tile_provider is the recommended way. Not using it leads to console warnings on web, therefore use it everywhere.
josxha
requested review from
JaffaKetchup,
TesteurManiak,
mootw and
ibrierley
TesteurManiak
requested changes
Nov 23, 2023
|
I'll have a review of this as well, a little later. |
There was a problem hiding this comment.
LGTM! (waiting for @JaffaKetchup's review before approving)
Added notice banners to some example pages Improved consistency across pages Removed unnecessary file in example source
|
@TesteurManiak @ignatz Let me know what you think. If you're happy @TesteurManiak feel free to approve and merge. |
josxha
commented
Nov 23, 2023
|
I only skimmed through the many lines. I only found a few pick-your-own-destiny nits. Looks like a great brush up. Thank you Josha |
TesteurManiak
approved these changes
Nov 24, 2023
|
Thanks @ignatz I appreciate it :) |
josxha
added a commit
to josxha/flutter_map
that referenced
this pull request
Nov 28, 2023
Co-authored-by: JaffaKetchup <[email protected]>
josxha
added a commit
that referenced
this pull request
Nov 28, 2023
Co-authored-by: JaffaKetchup <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
super.keyCancellableNetworkTileProvidereverywhere possible since it's the recommended way and to avoid console warningsCancellableTileProviderPageuse lint rules from the package for the example project tooMatch the lint rules with the package automaticallyflutter_lintsto^3.0.0