Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eagerly listen to TileLayer.reset stream to ensure handler is fired #1943

Merged
merged 2 commits into from
Sep 28, 2024

Merge branch 'master' into fix-reset-listener

8be9950
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix: eagerly listen to TileLayer.reset stream to ensure handler is fired #1943

Merge branch 'master' into fix-reset-listener
8be9950
Select commit
Loading
Failed to load commit list.
GitHub Actions / Analysis of flutter_map succeeded Sep 27, 2024 in 1m 28s

Package analysis results for flutter_map

Score

160/160 points
(100.0%)

Supported platforms

  • Flutter
    • android
    • ios
    • windows
    • linux
    • macos
    • web

Details

Follow Dart file conventions (30/30)

✔ 10/10 points: Provide a valid pubspec.yaml

✔ 5/5 points: Provide a valid README.md

✔ 5/5 points: Provide a valid CHANGELOG.md

✔ 10/10 points: Use an OSI-approved license

Detected license: BSD-3-Clause.

Provide documentation (20/20)

✔ 10/10 points: 20% or more of the public API has dartdoc comments

751 out of 781 API elements (96.2 %) have documentation comments.

Some symbols that are missing documentation: flutter_map.CirclePainter.camera, flutter_map.CirclePainter.hitNotifier, flutter_map.MapControllerImpl.fitCameraRaw, flutter_map.MapControllerImpl.vsync, flutter_map.MultiFingerGesture.all.

✔ 10/10 points: Package has an example

Platform support (20/20)

✔ 20/20 points: Supports 6 of 6 possible platforms (iOS, Android, Web, Windows, macOS, Linux)

  • ✓ Android

  • ✓ iOS

  • ✓ Windows

  • ✓ Linux

  • ✓ macOS

  • ✓ Web

These issues are present but do not affect the score, because they may not originate in your package:

Package not compatible with platform Web

Because:

  • package:flutter_map/flutter_map.dart that imports:
  • package:flutter_map/src/map/widget.dart that imports:
  • package:logger/logger.dart that imports:
  • package:logger/src/outputs/advanced_file_output_stub.dart that imports:
  • dart:io

❌ 0/0 points: WASM compatibility

Package not compatible with runtime wasm

Because:

  • package:flutter_map/flutter_map.dart that imports:
  • package:flutter_map/src/map/widget.dart that imports:
  • package:logger/logger.dart that imports:
  • package:logger/src/outputs/advanced_file_output_stub.dart that imports:
  • dart:io

This package is not compatible with runtime wasm, and will not be rewarded full points in a future version of the scoring model.

See https://dart.dev/web/wasm for details.

Pass static analysis (50/50)

✔ 50/50 points: code has no errors, warnings, lints, or formatting issues

Support up-to-date dependencies (40/40)

✔ 10/10 points: All of the package dependencies are supported in the latest version

Package Constraint Compatible Latest
async ^2.11.0 2.11.0 2.11.0
collection ^1.18.0 1.18.0 1.19.0
dart_earcut ^1.1.0 1.1.0 1.1.0
flutter flutter 0.0.0 0.0.0
http ^1.2.1 1.2.2 1.2.2
latlong2 ^0.9.1 0.9.1 0.9.1
logger ^2.0.0 2.4.0 2.4.0
meta ^1.11.0 1.15.0 1.16.0
polylabel ^1.0.1 1.0.1 1.0.1
proj4dart ^2.1.0 2.1.0 2.1.0
vector_math ^2.1.4 2.1.4 2.1.4
Transitive dependencies
Package Constraint Compatible Latest
characters - 1.3.0 1.3.0
clock - 1.1.1 1.1.1
http_parser - 4.0.2 4.1.0
intl - 0.19.0 0.19.0
lists - 1.0.1 1.0.1
material_color_utilities - 0.11.1 0.12.0
mgrs_dart - 2.0.0 2.0.0
path - 1.9.0 1.9.0
sky_engine - 0.0.99 0.0.99
source_span - 1.10.0 1.10.0
string_scanner - 1.3.0 1.3.0
term_glyph - 1.2.1 1.2.1
typed_data - 1.3.2 1.3.2
unicode - 0.3.1 0.3.1
web - 1.1.0 1.1.0
wkt_parser - 2.0.0 2.0.0

To reproduce run dart pub outdated --no-dev-dependencies --up-to-date --no-dependency-overrides.

✔ 10/10 points: Package supports latest stable Dart and Flutter SDKs

✔ 20/20 points: Compatible with dependency constraint lower bounds

pub downgrade does not expose any static analysis error.

Versions