Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet UI: Fix policy software automation fail to report as failing #26044

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RachelElysia
Copy link
Member

@RachelElysia RachelElysia commented Feb 4, 2025

Issue

For #25637

Description

  • concat was not modifying the original response array, errors were not actually being thrown to the try catch
  • await Promise.all(responses); will actually wait for all the API calls to complete and will throw an error if any of them fail

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality

@RachelElysia RachelElysia requested a review from a team as a code owner February 4, 2025 21:07
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.64%. Comparing base (df8e753) to head (b755cbc).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #26044   +/-   ##
=======================================
  Coverage   63.64%   63.64%           
=======================================
  Files        1631     1631           
  Lines      156293   156293           
  Branches     4088     4088           
=======================================
  Hits        99471    99471           
  Misses      48984    48984           
  Partials     7838     7838           
Flag Coverage Δ
frontend 53.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants