Acceslog: camelCase requestTime (#97)

flipkart-incubator · Aug 12, 2024 · d778de3 · d778de3
1 parent 2c4a386
commit d778de3
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/core/src/main/java/com/flipkart/gjex/core/context/AccessLogContext.java b/core/src/main/java/com/flipkart/gjex/core/context/AccessLogContext.java
@@ -61,7 +61,7 @@ private Map<String,Object> getValueMap() {
 
         if (requestTime != null) {
             String localDate = OffsetDateTime.ofInstant(Instant.ofEpochMilli(requestTime), ZoneId.systemDefault()).format(DateTimeFormatter.ISO_DATE_TIME);
-            params.put("request-time", localDate);
+            params.put("requestTime", localDate);
         }
         params.put("thread", Thread.currentThread().getName());
         if (userContext != null)

diff --git a/core/src/main/java/com/flipkart/gjex/core/filter/grpc/GrpcFilterConfig.java b/core/src/main/java/com/flipkart/gjex/core/filter/grpc/GrpcFilterConfig.java
@@ -34,5 +34,5 @@ public class GrpcFilterConfig {
     private boolean enableAccessLogs = true;
 
     @JsonProperty("accessLogFormat")
-    private String accessLogFormat = "{clientIp} - [{request-time}] \"{method} {resourcePath}\" {responseStatus} {contentLength} {responseTime}";
+    private String accessLogFormat = "{clientIp} - [{requestTime}] \"{method} {resourcePath}\" {responseStatus} {contentLength} {responseTime}";
 }
diff --git a/core/src/main/java/com/flipkart/gjex/core/filter/http/HttpFilterConfig.java b/core/src/main/java/com/flipkart/gjex/core/filter/http/HttpFilterConfig.java
@@ -34,6 +34,6 @@ public class HttpFilterConfig {
   private boolean enableAccessLogs = true;
 
   @JsonProperty("accessLogFormat")
-  private String accessLogFormat = "{clientIp} - [{request-time}] \"{method} {resourcePath} {protocol}\" {responseStatus} {contentLength} {responseTime} \"{referer}\" \"{userAgent}\"";
+  private String accessLogFormat = "{clientIp} - [{requestTime}] \"{method} {resourcePath} {protocol}\" {responseStatus} {contentLength} {responseTime} \"{referer}\" \"{userAgent}\"";
 
 }
diff --git a/examples/src/main/resources/hello_world_config.yml b/examples/src/main/resources/hello_world_config.yml
@@ -3,7 +3,7 @@ Grpc:
     server.executorThreads : 4
     filterConfig:
         enableAccessLogs: true
-        accessLogFormat: '{clientIp} - [{request-time}] "{method} {resourcePath} GRPC" {responseStatus} {contentLength} {responseTime} "-" "-"'
+        accessLogFormat: '{clientIp} - [{requestTime}] "{method} {resourcePath} GRPC" {responseStatus} {contentLength} {responseTime} "-" "-"'
 
 Dashboard:
     service.port: 9999
@@ -21,7 +21,7 @@ Api:
     healthcheck.path: "/elb-healthcheck"
     filterConfig:
         enableAccessLogs: true
-        accessLogFormat: '{clientIp} - [{request-time}] "{method} {resourcePath} {protocol}" {responseStatus} {contentLength} {responseTime} "{referer}" "{userAgent}"'
+        accessLogFormat: '{clientIp} - [{requestTime}] "{method} {resourcePath} {protocol}" {responseStatus} {contentLength} {responseTime} "{referer}" "{userAgent}"'
 
 Tracing:
     collector.endpoint: http://localhost:9411/api/v2/spans