Skip to content

Commit

Permalink
try to fix notarizing
Browse files Browse the repository at this point in the history
  • Loading branch information
mholtzman committed Jan 17, 2025
1 parent 6428ffd commit 8b3e2f3
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,18 +36,18 @@ jobs:
strategy:
fail-fast: false
matrix:
os:
- ubuntu-latest
# os:
# - ubuntu-latest
include:
- os: macos-13
cert_key: APPLE_DEVELOPER_SIGNING_CERTIFICATE
cert_password_key: APPLE_CERTIFICATE_PASSWORD
apple_id_key: APPLE_ID
apple_app_specific_password_key: APPLE_ID_PASSWORD
apple_team_id_key: APPLE_TEAM_ID
- os: windows-latest
cert_key: WINDOWS_CSC_CERTIFICATE
cert_password_key: WINDOWS_CSC_PASSWORD
# - os: windows-latest
# cert_key: WINDOWS_CSC_CERTIFICATE
# cert_password_key: WINDOWS_CSC_PASSWORD

runs-on: ${{ matrix.os }}

Expand Down
4 changes: 3 additions & 1 deletion build/notarize.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,12 @@ module.exports = async function (params) {

try {
await electronNotarize.notarize({
tool: 'notarytool',
appBundleId: appId,
appPath: appPath,
appleId: process.env.APPLE_ID,
appleIdPassword: process.env.APPLE_APP_SPECIFIC_PASSWORD
appleIdPassword: process.env.APPLE_APP_SPECIFIC_PASSWORD,
teamId: process.env.APPLE_TEAM_ID
})

// verify signed and notarized application
Expand Down

0 comments on commit 8b3e2f3

Please sign in to comment.