-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using the standards format (requirements.txt) for Python deps. #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there!
Thanks for your contribution.
The requirements.txt
is more a common way to express dependencies for pip
(and pip only) than a real standard.
I am missing the "why" for this PR. What value does this change provide in contrast to the old variant? Currently, this PR just moves the location where dependencies are stored.
Maybe freeze the versions of the dependencies in the requirements.txt
? This would add the value of locking the dependencies for everyone.
With locked dependencies, I would happily accept this PR.
Having the dependecies in a machine readable format is useful in the long term. That was the whole goal. There might not be a a full agreement from all Pyhon tools to use the file. But its widely used enough and well specified enough for me: https://pip.pypa.io/en/stable/reference/requirements-file-format/
I'm not familiar enough with the code to determine the min/max versions for dependencies. Arguably, its not even a good idea to pin the versions of dependencies. The current way of From the Readme.md showing |
I disagree.
This may be true and I agree that we should always use the latest stable software, but without pinning we are not able to guarantee this and people are notoriously bad at keeping their software up to date.
This is pretty much a non-concern, as it is trivial to automate. I'll be happy to add Renovate Bot to this Repo. See #23 Now, that said, pinning versions for this project isn't that critical as we only consume software instead of creating it. But I still would like to add version pinning as it is good practice.
Currently, we could just use the latest versions as a starting point. As far as I know we do not use any special features. A fresh install and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it does not hurt and it is an incremental step towards dependency pinning. I will accept your PR.
Thanks for your contribution!
No description provided.