Require double swipe up if there is an app swipe recognizer from the bottom #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 13, 2018 11:54
|
Hey @pvinis thanks for your contribution. Im currently on vacation. Im going to review and test your code next week when im back in the office |
|
Hey @pvinis. Can you provide a reproduction that describes the issue you’re fixing here? The solution looks kind of brittle to me. I think the touch handling of UIKit should be able to handle this if the recognizers are set up correctly. Feel free to reopen if you think I am wrong |
|
hi, so this was mostly for the app we have, because we have a video playing on landscape, and the scrollbar is on the bottom, so i wanted to disable the home indicator from doing the app swiping basically. i can make a quick demo and reopen this. |
|
@michaelknoch this fixes #23. What makes you feel like this solution is brittle? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.