new login flow #209
Merged
new login flow #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houqp
force-pushed
the
login
branch
6 times, most recently
from
5db61ec to
262c3d2
Compare
narenst
reviewed
Oct 5, 2018
floyd/cli/auth.py
Outdated
| subprocess.check_output( | ||
| [sys.executable, '-m', 'webbrowser', url], stderr=subprocess.STDOUT) | ||
|
|
||
| floyd_logger.info('waiting for login from browser...') |
There was a problem hiding this comment.
This should be printed earlier than this - may be at the top of this function.
When I ran login, there was no output for a few seconds and then the browser opened - I did not see this message until I came back to the terminal.
floyd/cli/auth.py
Outdated
| from queue import Queue | ||
|
|
||
|
|
||
| class LoginServer(HTTPServer, object): |
There was a problem hiding this comment.
The web server code can be moved to a its own file under managers.
houqp
force-pushed
the
login
branch
2 times, most recently
from
4756d55 to
28779b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.