Feature Request: Download a directory inside the output using cli #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narenst
reviewed
Nov 26, 2018
floyd/cli/data.py
Outdated
|
|
||
| (e.g. foo/projects/bar/1/files, foo/projects/bar/1/output or foo/dataset/bar/1/ | ||
|
|
||
| This will download the files that are returned at |
There was a problem hiding this comment.
Suggested change
| This will download the files that are returned at | |
| This will download the files that are saved at |
floyd/cli/data.py
Outdated
| data_url = "{}/api/v1/resources/{}?content=true&download=true".format(floyd.floyd_host, | ||
| data_source.resource_id) | ||
| # Download a directory from Dataset or Files | ||
| else: |
There was a problem hiding this comment.
For readability, can you change the if condition and swap these cases?
if directory:
# Download a directory from Dataset or files
...
else:
...
floyd/cli/data.py
Outdated
| @@ -141,9 +143,17 @@ def print_data(data_sources): | |||
|
|
|||
| @click.command() | |||
| @click.argument('id', nargs=1) | |||
| def clone(id): | |||
| @click.option('--directory', '-d', | |||
There was a problem hiding this comment.
It would more obvious to call this option --path instead of directory.
floyd/cli/data.py
Outdated
| @@ -141,9 +143,17 @@ def print_data(data_sources): | |||
|
|
|||
| @click.command() | |||
| @click.argument('id', nargs=1) | |||
| def clone(id): | |||
| @click.option('--directory', '-d', | |||
| help='Download a directory from Job output or a dataset') | |||
There was a problem hiding this comment.
Suggested change
| help='Download a directory from Job output or a dataset') | |
| help='Download files in a specific path from job output or a dataset') |
floyd/cli/data.py
Outdated
| - Download all files in a dataset or from Job output | ||
| - Download a directory from a dataset or from Job output | ||
|
|
||
| (e.g. foo/projects/bar/1/files, foo/projects/bar/1/output or foo/dataset/bar/1/ |
There was a problem hiding this comment.
This documentation is a bit difficult to follow. Here is my recommendation:
- Download all files in a dataset or from a Job output
Eg: alice/projects/mnist/1/files, alice/projects/mnist/1/output or alice/dataset/mnist-data/1/
Using /output will download the files that are saved at the end of the job.
- Download a directory from a dataset or from Job output
Specify the path to a directory and download all its files and subdirectories.
Eg: --path models/checkpoint1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it's possible to download a directory from a Job or dataset with the
floyd [data] clone --directory <dir_name> ID